jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385250 )
Change subject: Use standard close icon ...................................................................... Use standard close icon Making use of standard close icon and add `opacity` transition for slight user feedback on states. Bug: T50067 Change-Id: I258a50452eba8f9d0bfb550c2ad1a90ef7b6dc1f --- M resources/ext.popups.images/close.svg M resources/ext.popups/styles/ext.popups.settings.less 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, but someone else must approve Jdlrobson: Looks good to me, approved diff --git a/resources/ext.popups.images/close.svg b/resources/ext.popups.images/close.svg index 772a0ef..22619b9 100644 --- a/resources/ext.popups.images/close.svg +++ b/resources/ext.popups.images/close.svg @@ -1,5 +1,5 @@ -<?xml version="1.0" encoding="utf-8"?> -<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 24 24"> - <path d="M4.983 1.606l17.465 17.466-2.97 2.97L2.014 4.575z"/> - <path d="M19.407 1.605l2.97 2.97L4.914 22.042l-2.97-2.97z"/> +<?xml version="1.0" encoding="UTF-8"?> +<svg xmlns="http://www.w3.org/2000/svg"; width="20" height="20" viewBox="0 0 20 20"> + <path d="M3.636 2.222l14.142 14.142-1.414 1.414L2.222 3.636z"/> + <path d="M17.778 3.636L3.636 17.778l-1.414-1.414L16.364 2.222z"/> </svg> diff --git a/resources/ext.popups/styles/ext.popups.settings.less b/resources/ext.popups/styles/ext.popups.settings.less index 6416f91..dc9e242 100644 --- a/resources/ext.popups/styles/ext.popups.settings.less +++ b/resources/ext.popups/styles/ext.popups.settings.less @@ -35,6 +35,19 @@ } } + .mwe-ui-icon-popups-close { + opacity: 0.87; // = `#222` on `background-color: #fff` + .transition( opacity 100ms ); + + &:hover { + opacity: 0.73; // = `#454545` on `background-color: #fff`, closest to `#444` + } + + &:active { + opacity: 1; + } + } + main { display: block; width: 350px; -- To view, visit https://gerrit.wikimedia.org/r/385250 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I258a50452eba8f9d0bfb550c2ad1a90ef7b6dc1f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: VolkerE <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jforrester <[email protected]> Gerrit-Reviewer: Pmiazga <[email protected]> Gerrit-Reviewer: VolkerE <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
