Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/56068


Change subject: WTS: Added missing cb('', node) for some meta's
......................................................................

WTS: Added missing cb('', node) for some meta's

* On the following wikitext snippet (without the leading indent),
  the newline after the "|\n" was being lost because the tpl-affected
  meta in the <td><meta .. ></td> was not emitting sep-from-source.
  In turn, this was because the meta-dom-handler was missing a
  cb('', node) callback -- which in the no-original-source case,
  is unnecessary and excess work, but in the have-original-source
  case, is required to ensure that separator from original source
  is output.

        {|
        |a
        |
        |{{Party shading/Federalist}} | a
        |}

* No change in parser test results.

* Fixes semantic errors on en:Delaware_gubernatorial_elections

Change-Id: I6a7e309d657c0aac604c779e1f67954ccbfa3bce
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/68/56068/1

diff --git a/js/lib/mediawiki.WikitextSerializer.js 
b/js/lib/mediawiki.WikitextSerializer.js
index 4e0b186..6036218 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -1634,7 +1634,7 @@
                                //state.sep.src = trailingSep && trailingSep[0] 
|| '';
                                state.sep.src = '';
                        }
-                               state.inIndentPre = false;
+                       state.inIndentPre = false;
                },
                sepnls: {
                        before: function(node, otherNode) {
@@ -1699,6 +1699,8 @@
                                                switchType = 
node.data.parsoid.magicSrc;
                                        }
                                        cb(switchType, node);
+                               } else {
+                                       cb('', node);
                                }
                        } else {
                                WSP._htmlElementHandler(node, state, cb);

-- 
To view, visit https://gerrit.wikimedia.org/r/56068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a7e309d657c0aac604c779e1f67954ccbfa3bce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to