jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/388544 )
Change subject: [DEPRECATING CHANGE] Use en-US spelling for icon names for
consistency
......................................................................
[DEPRECATING CHANGE] Use en-US spelling for icon names for consistency
Deprecate 'alignCentre' for 'alignCenter'.
Change-Id: I7f80898a33eb597ee20422b72077dc28d789116f
---
M demos/pages/icons.js
M src/themes/apex/icons-editing-advanced.json
M src/themes/wikimediaui/icons-editing-advanced.json
3 files changed, 11 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index 7c459c9..8ae0e63 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -118,7 +118,7 @@
'outdent'
],
'editing-advanced': [
- 'alignCentre',
+ 'alignCenter',
'alignLeft',
'alignRight',
'attachment',
diff --git a/src/themes/apex/icons-editing-advanced.json
b/src/themes/apex/icons-editing-advanced.json
index a3c5773..432d7df 100644
--- a/src/themes/apex/icons-editing-advanced.json
+++ b/src/themes/apex/icons-editing-advanced.json
@@ -2,7 +2,11 @@
"prefix": "oo-ui-icon",
"intro": "@import '../../../../src/styles/common';",
"images": {
- "alignCentre": { "file": "images/icons/align-center.svg" },
+ "alignCenter": { "file": "images/icons/align-center.svg" },
+ "alignCentre": {
+ "file": "images/icons/align-center.svg",
+ "deprecated": "Replaced since v0.24.2, use
'alignCenter' instead."
+ },
"alignLeft": { "file": "images/icons/align-float-left.svg" },
"alignRight": { "file": "images/icons/align-float-right.svg" },
"attachment": { "file": {
diff --git a/src/themes/wikimediaui/icons-editing-advanced.json
b/src/themes/wikimediaui/icons-editing-advanced.json
index 36301fc..7952c60 100644
--- a/src/themes/wikimediaui/icons-editing-advanced.json
+++ b/src/themes/wikimediaui/icons-editing-advanced.json
@@ -22,7 +22,11 @@
}
},
"images": {
- "alignCentre": { "file": "images/icons/align-center.svg" },
+ "alignCenter": { "file": "images/icons/align-center.svg" },
+ "alignCentre": {
+ "file": "images/icons/align-center.svg",
+ "deprecated": "Replaced since v0.24.2, use
'alignCenter' instead."
+ },
"alignLeft": { "file": "images/icons/align-float-left.svg" },
"alignRight": { "file": "images/icons/align-float-right.svg" },
"attachment": { "file": {
--
To view, visit https://gerrit.wikimedia.org/r/388544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f80898a33eb597ee20422b72077dc28d789116f
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
