Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388681 )

Change subject: Annoying findbugs tries to optimize my code and blocks builds.
......................................................................

Annoying findbugs tries to optimize my code and blocks builds.

Annoying findbugs is annoying.

Change-Id: I3356409f05ccabd77de284d91fa1147abe6274cc
---
M 
blazegraph/src/main/java/org/wikidata/query/rdf/blazegraph/label/EmptyLabelServiceOptimizer.java
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/81/388681/1

diff --git 
a/blazegraph/src/main/java/org/wikidata/query/rdf/blazegraph/label/EmptyLabelServiceOptimizer.java
 
b/blazegraph/src/main/java/org/wikidata/query/rdf/blazegraph/label/EmptyLabelServiceOptimizer.java
index 3e6a4e0..d7edf93 100644
--- 
a/blazegraph/src/main/java/org/wikidata/query/rdf/blazegraph/label/EmptyLabelServiceOptimizer.java
+++ 
b/blazegraph/src/main/java/org/wikidata/query/rdf/blazegraph/label/EmptyLabelServiceOptimizer.java
@@ -62,7 +62,9 @@
                 break;
             }
 
-            foundArg = 
EmptyLabelServiceOptimizer.this.restoreExtracted(service) || foundArg;
+            if (EmptyLabelServiceOptimizer.this.restoreExtracted(service)) {
+                foundArg = true;
+            }
 
             if (!foundArg) {
                 EmptyLabelServiceOptimizer.this.addResolutions(ctx, g, 
root.getProjection());

-- 
To view, visit https://gerrit.wikimedia.org/r/388681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3356409f05ccabd77de284d91fa1147abe6274cc
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to