jenkins-bot has submitted this change and it was merged.
Change subject: Add FIXMEs
......................................................................
Add FIXMEs
Based on PHP error logging and CR.
Change-Id: I4a260ab3cb4d30f8e8e121ccad9c51f5c3ab0bb7
---
M MainPage/CachedStat.php
M MainPage/ProjectHandler.php
M MainPage/specials/SpecialTwnMainPage.php
3 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MainPage/CachedStat.php b/MainPage/CachedStat.php
index f215e8c..d6011c3 100644
--- a/MainPage/CachedStat.php
+++ b/MainPage/CachedStat.php
@@ -61,6 +61,7 @@
$value = $this->doUpdate();
}
+ // @todo FIXME: PHP Notice: Undefined index: t in
CachedStat.php
if ( $value['t'] + $this->staleAge < wfTimestamp( TS_UNIX ) ) {
// Useless
// DeferredUpdates::addUpdate( $this );
@@ -68,6 +69,7 @@
CachedStatJob::newJob( $this )->insert();
}
+ // @todo FIXME: PHP Notice: Undefined index: v in
CachedStat.php
return $value['v'];
}
diff --git a/MainPage/ProjectHandler.php b/MainPage/ProjectHandler.php
index ce90607..5969596 100644
--- a/MainPage/ProjectHandler.php
+++ b/MainPage/ProjectHandler.php
@@ -8,7 +8,6 @@
*/
class ProjectHandler {
-
public static function getProjects() {
$projects = array();
$groups = MessageGroups::getGroupStructure();
@@ -27,6 +26,8 @@
return $projects;
}
+ // @todo FIXME: This is duplicate code Translate -
ApiQueryMessageGroup. We can avoid
+ // duplication if we make getIcon of that API public static.
public static function getIcon( MessageGroup $g, $size ) {
global $wgServer;
$icon = $g->getIcon();
diff --git a/MainPage/specials/SpecialTwnMainPage.php
b/MainPage/specials/SpecialTwnMainPage.php
index 34c8873..27b0916 100644
--- a/MainPage/specials/SpecialTwnMainPage.php
+++ b/MainPage/specials/SpecialTwnMainPage.php
@@ -309,6 +309,7 @@
$stats = $statsArray['translators'];
$i = 1;
$translators = count( $stats );
+ // @todo FIXME: PHP Warning: Invalid argument supplied for
foreach() in SpecialTwnMainPage.php
foreach ( $stats as $user => $count ) {
if ( $user === $myuser ) {
$out .= Html::element( 'div', array( 'class' =>
'count' ), $count );
@@ -330,6 +331,7 @@
$stats = $statsArray['proofreaders'];
$i = 1;
$translators = count( $stats );
+ // @todo FIXME: PHP Warning: Invalid argument supplied for
foreach() in SpecialTwnMainPage.php
foreach ( $stats as $user => $count ) {
if ( $user === $myuser ) {
$out .= Html::element( 'div', array( 'class' =>
'count' ), $count );
--
To view, visit https://gerrit.wikimedia.org/r/55591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a260ab3cb4d30f8e8e121ccad9c51f5c3ab0bb7
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
