jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/388678 )
Change subject: Minor clean ups to class and method level PHPDocs
......................................................................
Minor clean ups to class and method level PHPDocs
I'm removing constructor "documentation" that does not add anything
to whats already obvious from the "__constructor" method name and the
class name.
Change-Id: I094aa697f892225f37edeb1a1011caa2398f14bb
---
M includes/CentralAuthUnattachUserJob.php
M includes/CentralAuthUser.php
M includes/SuppressUserJob.php
M includes/specials/SpecialSulRenameWarning.php
M maintenance/sendConfirmAndMigrateEmail.php
5 files changed, 3 insertions(+), 11 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CentralAuthUnattachUserJob.php
b/includes/CentralAuthUnattachUserJob.php
index 0753799..abc22f3 100644
--- a/includes/CentralAuthUnattachUserJob.php
+++ b/includes/CentralAuthUnattachUserJob.php
@@ -27,8 +27,6 @@
class CentralAuthUnattachUserJob extends Job {
/**
- * Constructor
- *
* @param Title $title Associated title
* @param array $params Job parameters
*/
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index e2705d0..6a842b7 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -1273,9 +1273,9 @@
* the password check.
*
* @param string $password plaintext password to try matching
- * @param array &$migrated array of wiki IDs for records which were
+ * @param string[] &$migrated Array of wiki IDs for records which were
* successfully migrated by this operation
- * @param array &$remaining of wiki IDs for records which are still
+ * @param string[] &$remaining Array of wiki IDs for records which are
still
* unattached after the operation
* @return bool true if all accounts are migrated at the end
*/
diff --git a/includes/SuppressUserJob.php b/includes/SuppressUserJob.php
index dbdd723..d85a232 100644
--- a/includes/SuppressUserJob.php
+++ b/includes/SuppressUserJob.php
@@ -7,8 +7,6 @@
*/
class CentralAuthSuppressUserJob extends Job {
/**
- * Constructor
- *
* @param Title $title Associated title
* @param array $params Job parameters
*/
diff --git a/includes/specials/SpecialSulRenameWarning.php
b/includes/specials/SpecialSulRenameWarning.php
index e1327dc..aa87c64 100644
--- a/includes/specials/SpecialSulRenameWarning.php
+++ b/includes/specials/SpecialSulRenameWarning.php
@@ -27,9 +27,7 @@
* @copyright © 2014 Bryan Davis and Wikimedia Foundation.
*/
class SpecialSulRenameWarning extends UnlistedSpecialPage {
- /**
- * Constructor.
- */
+
public function __construct() {
parent::__construct( 'SulRenameWarning' );
}
diff --git a/maintenance/sendConfirmAndMigrateEmail.php
b/maintenance/sendConfirmAndMigrateEmail.php
index 4e52436..67a7fbb 100644
--- a/maintenance/sendConfirmAndMigrateEmail.php
+++ b/maintenance/sendConfirmAndMigrateEmail.php
@@ -7,8 +7,6 @@
require_once "$IP/maintenance/Maintenance.php";
/**
- * Class SendConfirmAndMigrateEmail
- *
* This maintenance script is used to resend confirmation emails to users with
* unattached accounts in the hopes that we will then be able to automatically
* attach some unattached accounts. In addition, by using an EmailableUser
object
--
To view, visit https://gerrit.wikimedia.org/r/388678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I094aa697f892225f37edeb1a1011caa2398f14bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
