SimmeD has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/389324 )
Change subject: Cleanup
......................................................................
Cleanup
I've renamed a variables to follow normal variable style.
Also, added doc on a constructor and added a space in class.
Change-Id: I915ea7f4b0f8b72f0188932b27579cdff5e641dd
---
M Newsletter.hooks.php
M includes/NewsletterStore.php
M maintenance/updateSubscribersCount.php
3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/24/389324/1
diff --git a/Newsletter.hooks.php b/Newsletter.hooks.php
index e875b1f..6ba49aa 100644
--- a/Newsletter.hooks.php
+++ b/Newsletter.hooks.php
@@ -303,16 +303,16 @@
/**
* @param Title $title
- * @param Title $newtitle
+ * @param Title $newTitle
* @param User $user
* @return bool
* @throws MWException
*/
- public static function onTitleMove( Title $title, Title $newtitle, User
$user ) {
- if ( $newtitle->inNamespace( NS_NEWSLETTER ) ) {
+ public static function onTitleMove( Title $title, Title $newTitle, User
$user ) {
+ if ( $newTitle->inNamespace( NS_NEWSLETTER ) ) {
$newsletter = Newsletter::newFromName(
$title->getText() );
if ( $newsletter ) {
-
NewsletterStore::getDefaultInstance()->updateName( $newsletter->getId(),
$newtitle->getText() );
+
NewsletterStore::getDefaultInstance()->updateName( $newsletter->getId(),
$newTitle->getText() );
} else {
throw new MWException( 'Cannot find newsletter
with name \"' . $title->getText() . '\"' );
}
diff --git a/includes/NewsletterStore.php b/includes/NewsletterStore.php
index 0ce7d7f..ecb79b7 100644
--- a/includes/NewsletterStore.php
+++ b/includes/NewsletterStore.php
@@ -21,6 +21,12 @@
*/
private static $instance;
+ /**
+ * Constructor.
+ *
+ * @param NewsletterDb $db
+ * @param NewsletterLogger $logger
+ */
public function __construct( NewsletterDb $db, NewsletterLogger $logger
) {
$this->db = $db;
$this->logger = $logger;
diff --git a/maintenance/updateSubscribersCount.php
b/maintenance/updateSubscribersCount.php
index 25c6611..d1ede7d 100644
--- a/maintenance/updateSubscribersCount.php
+++ b/maintenance/updateSubscribersCount.php
@@ -5,6 +5,7 @@
require_once $basePath . '/maintenance/Maintenance.php';
class UpdateSubscribersCount extends Maintenance {
+
public function __construct() {
parent::__construct();
$this->addDescription(
--
To view, visit https://gerrit.wikimedia.org/r/389324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I915ea7f4b0f8b72f0188932b27579cdff5e641dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: SimmeD <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
