jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/389659 )
Change subject: demos: Correct and simplify SimpleWidget styles
......................................................................
demos: Correct and simplify SimpleWidget styles
* This widget does not mix in IndicatorElement, therefore all styles
for `.oo-ui-indicatorElement` and `.oo-ui-indicatorElement-indicator`
are unnecessary.
* Remove unnecessary duplicate styles for `.oo-ui-iconElement-icon`.
Out of `top`, `bottom`, `left`, `right`, and `height`, we actually
only need to set `left` here, others are already set in IconElement
styles or superfluous.
* `.demo-simpleWidget` can never also be a `.oo-ui-labelElement-label`
(the label is a child element), correct this to instead apply to
`.demo-simpleWidget.oo-ui-labelElement`.
* Reorder stuff a little bit to keep related styles closer.
Change-Id: I4de8df280ae32fdd75a2db7d47a117d9e2c5a06a
---
M demos/classes/SimpleWidget.css
1 file changed, 3 insertions(+), 20 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/demos/classes/SimpleWidget.css b/demos/classes/SimpleWidget.css
index b7f501f..04f0844 100644
--- a/demos/classes/SimpleWidget.css
+++ b/demos/classes/SimpleWidget.css
@@ -5,10 +5,8 @@
line-height: 1;
}
-.demo-simpleWidget.oo-ui-iconElement .oo-ui-iconElement-icon,
-.demo-simpleWidget.oo-ui-indicatorElement .oo-ui-indicatorElement-indicator {
- top: 0;
- height: 100%;
+.demo-simpleWidget.oo-ui-labelElement {
+ line-height: 1.172em;
}
.demo-simpleWidget.oo-ui-iconElement {
@@ -17,24 +15,9 @@
.demo-simpleWidget.oo-ui-iconElement .oo-ui-iconElement-icon {
position: absolute;
- bottom: 0;
- right: 0;
left: 0.9375em;
}
-.demo-simpleWidget.oo-ui-labelElement-label {
- line-height: 1.172em;
-}
-
-.demo-simpleWidget.oo-ui-indicatorElement {
- padding-right: 2.5em;
-}
-
-.demo-simpleWidget.oo-ui-indicatorElement-indicator {
- right: 0.9375em;
-}
-
-.demo-simpleWidget.oo-ui-widget-disabled .oo-ui-iconElement-icon,
-.demo-simpleWidget.oo-ui-widget-disabled .oo-ui-indicatorElement-indicator {
+.demo-simpleWidget.oo-ui-widget-disabled .oo-ui-iconElement-icon {
opacity: 0.51;
}
--
To view, visit https://gerrit.wikimedia.org/r/389659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4de8df280ae32fdd75a2db7d47a117d9e2c5a06a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
