jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/385407 )
Change subject: Report filesize, and don't delete misc props from intermediate
response
......................................................................
Report filesize, and don't delete misc props from intermediate response
A client might actually want to know a media file size, so let's pass it
through to the result.
The other properties' being in the intermediate response doesn't matter.
Bug: T177430
Change-Id: Ie62f9395828b8217241e452b4b211d82e35fffff
---
M lib/media.js
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/media.js b/lib/media.js
index 7e9a66e..e36d308 100644
--- a/lib/media.js
+++ b/lib/media.js
@@ -58,6 +58,7 @@
mime: obj.mime,
width: obj.width,
height: obj.height,
+ size: obj.size,
derivatives: obj.derivatives,
ext: getExtMetadataValues(obj.extmetadata)
};
@@ -112,12 +113,6 @@
});
items.forEach((item) => {
- delete item.ns;
- delete item.imagerepository; // we probably don't care where the repo
is
- delete item.imageinfo[0].size;
- // TODO: instead of deleting properties we probably want to just add
well-known
- // properties
-
const mime = item.imageinfo[0].mime;
isVideo = mime.indexOf('ogg') > -1 || mime.indexOf('video') > -1;
--
To view, visit https://gerrit.wikimedia.org/r/385407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie62f9395828b8217241e452b4b211d82e35fffff
Gerrit-PatchSet: 11
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: Ppchelko <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
