Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390190 )
Change subject: Revert "resources: Remove deprecated 'jquery.placeholder'
module"
......................................................................
Revert "resources: Remove deprecated 'jquery.placeholder' module"
This reverts commit 235e92846eb6fd132f28ec5e05240e3821542ac8.
Change-Id: Icc8c93dc6e4b5d09dc424eda5ffc9034f67128e1
---
M RELEASE-NOTES-1.31
M resources/Resources.php
A resources/src/jquery/jquery.placeholder.js
M resources/src/mediawiki.less/mediawiki.mixins.less
4 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/90/390190/1
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 09f0dc9..0544d59 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -32,7 +32,6 @@
==== Removed and replaced external libraries ====
* The deprecated 'jquery.autoEllipsis' module was removed. Use the CSS
text-overflow property instead.
-* The deprecated 'jquery.placeholder' module was removed.
* The deprecated 'jquery.appear' module was removed. Use the
'mediawiki.viewport' module instead.
* The deprecated 'mediawiki.widgets.CategorySelector' module alias was removed.
diff --git a/resources/Resources.php b/resources/Resources.php
index 81e0f02..e2065cb 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -288,6 +288,12 @@
'scripts' => 'resources/src/jquery/jquery.mw-jump.js',
'targets' => [ 'desktop', 'mobile' ],
],
+ 'jquery.placeholder' => [
+ 'deprecated' => 'Use of "jquery.placeholder" is deprecated
since MediaWiki 1.29.0',
+
+ 'scripts' => 'resources/src/jquery/jquery.placeholder.js',
+ 'targets' => [ 'desktop', 'mobile' ],
+ ],
'jquery.qunit' => [
'scripts' => 'resources/lib/qunitjs/qunit.js',
'styles' => 'resources/lib/qunitjs/qunit.css',
diff --git a/resources/src/jquery/jquery.placeholder.js
b/resources/src/jquery/jquery.placeholder.js
new file mode 100644
index 0000000..afb8837
--- /dev/null
+++ b/resources/src/jquery/jquery.placeholder.js
@@ -0,0 +1,18 @@
+/*!
+ * No-op for compatibility with code from before we used
+ * native placeholder in all supported browsers.
+ */
+
+( function ( $ ) {
+ var placeholder;
+
+ placeholder = $.fn.placeholder = function ( text ) {
+ if ( arguments.length ) {
+ this.prop( 'placeholder', text );
+ }
+ return this;
+ };
+
+ placeholder.input = placeholder.textarea = true;
+
+}( jQuery ) );
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less
b/resources/src/mediawiki.less/mediawiki.mixins.less
index ea0b959..fb3b00e 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -171,6 +171,10 @@
&::placeholder {
@rules();
}
+ // For inputs that use jquery.placeholder.js e.g. IE9
+ &.placeholder {
+ @rules();
+ }
}
/* stylelint-enable selector-no-vendor-prefix, at-rule-no-unknown */
--
To view, visit https://gerrit.wikimedia.org/r/390190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc8c93dc6e4b5d09dc424eda5ffc9034f67128e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
