jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/387195 )
Change subject: SVG Sprites - Fixing IE8 issues ...................................................................... SVG Sprites - Fixing IE8 issues Fixing SVG fallback issues in IE8. Providing a properly scaled 1x Wikinews logo since IE8 doesn't support background-size. Adding a 2x logo for any screen above 120dpi Bug: T129634 Change-Id: I6056662f6a29b4cf4f8268b41f0713123a25d985 --- M dev/wikipedia.org/assets/img/Wikinews-logo_sister.png A dev/wikipedia.org/assets/img/[email protected] M dev/wikipedia.org/assets/postcss/_central-textlogo.css M dev/wikipedia.org/assets/postcss/_other-projects.css 4 files changed, 8 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified VolkerE: Looks good to me, approved diff --git a/dev/wikipedia.org/assets/img/Wikinews-logo_sister.png b/dev/wikipedia.org/assets/img/Wikinews-logo_sister.png index cdd0814..6a68039 100644 --- a/dev/wikipedia.org/assets/img/Wikinews-logo_sister.png +++ b/dev/wikipedia.org/assets/img/Wikinews-logo_sister.png Binary files differ diff --git a/dev/wikipedia.org/assets/img/[email protected] b/dev/wikipedia.org/assets/img/[email protected] new file mode 100644 index 0000000..09ea345 --- /dev/null +++ b/dev/wikipedia.org/assets/img/[email protected] Binary files differ diff --git a/dev/wikipedia.org/assets/postcss/_central-textlogo.css b/dev/wikipedia.org/assets/postcss/_central-textlogo.css index ed60d49..cdde631 100644 --- a/dev/wikipedia.org/assets/postcss/_central-textlogo.css +++ b/dev/wikipedia.org/assets/postcss/_central-textlogo.css @@ -32,6 +32,7 @@ color: transparent; display: inline-block; overflow: hidden; + text-indent: -10000px; } @media all and ( max-width: 480px ) { diff --git a/dev/wikipedia.org/assets/postcss/_other-projects.css b/dev/wikipedia.org/assets/postcss/_other-projects.css index 86682c0..16c11aa 100644 --- a/dev/wikipedia.org/assets/postcss/_other-projects.css +++ b/dev/wikipedia.org/assets/postcss/_other-projects.css @@ -30,11 +30,17 @@ .svg-Wikinews-logo_sister { background-image: url( portal/wikipedia.org/assets/img/Wikinews-logo_sister.png ); background-position: 0 0; - background-size: 47px auto; + background-size: 47px 26px; width: 47px; height: 26px; } +@media ( min-resolution: 120dpi ) { + .svg-Wikinews-logo_sister { + background-image: url( portal/wikipedia.org/assets/img/[email protected] ); + } +} + .other-project .sprite-project-logos { display: inline-block; } -- To view, visit https://gerrit.wikimedia.org/r/387195 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6056662f6a29b4cf4f8268b41f0713123a25d985 Gerrit-PatchSet: 12 Gerrit-Project: wikimedia/portals Gerrit-Branch: master Gerrit-Owner: Jdrewniak <[email protected]> Gerrit-Reviewer: Jdrewniak <[email protected]> Gerrit-Reviewer: Mxn <[email protected]> Gerrit-Reviewer: VolkerE <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
