Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390362 )
Change subject: version: Don't rely on git.wikimedia.org
......................................................................
version: Don't rely on git.wikimedia.org
It's dead. Use Gerrit's API instead.
Bug: T139089
Change-Id: Ic4917c6814406ad1d10397f6d9eef5382b34f8ef
---
M pywikibot/version.py
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/62/390362/1
diff --git a/pywikibot/version.py b/pywikibot/version.py
index c48db41..5838707 100644
--- a/pywikibot/version.py
+++ b/pywikibot/version.py
@@ -14,6 +14,7 @@
import codecs
import datetime
+import json
import os
import subprocess
import sys
@@ -364,19 +365,17 @@
return (tag, rev, date, hsh)
-def getversion_onlinerepo(repo=None):
- """Retrieve current framework revision number from online repository.
-
- @param repo: (optional) Online repository location
- @type repo: URL or string
+def getversion_onlinerepo():
+ """Retrieve current framework git hash from Gerrit
"""
from pywikibot.comms import http
- url = repo or 'https://git.wikimedia.org/feed/pywikibot/core'
+ url =
'https://gerrit.wikimedia.org/r/projects/pywikibot%2Fcore/branches/master'
buf = http.fetch(uri=url,
- headers={'user-agent': '{pwb}'}).content.splitlines()
+ headers={'user-agent': '{pwb}'}).content[4:]
+
try:
- hsh = buf[13].split('/')[5][:-1]
+ hsh = json.loads(buf)['revision']
return hsh
except Exception as e:
raise ParseError(repr(e) + ' while parsing ' + repr(buf))
--
To view, visit https://gerrit.wikimedia.org/r/390362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4917c6814406ad1d10397f6d9eef5382b34f8ef
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
