Tim Starling has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390365 )
Change subject: To identify superseded requests, use the requested search term
instead of the returned search term
......................................................................
To identify superseded requests, use the requested search term instead of the
returned search term
Previously, the search suggestions dropdown would be updated only if the
the search term in the response matched the most recently dispatched
search term. This was supposed to suppress out-of-order responses. However,
it had the undesired effect of suppressing all responses in which the
search term is changed by MediaWiki's Unicode normalisation.
It's not sufficient to run NFC on the client-side, since MediaWiki's
Unicode cleanup routine is not precisely the same as NFC. Also, NFC
changes from one Unicode version to the next. And also, it is slow.
So, use the term precisely as requested to identify responses. It is
already available in the relevant closure.
Bug: T170779
Change-Id: Id0d1d081e921a0f24a380260dcb5186d98e443a9
---
M view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/65/390365/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
index c2126b2..55ffada 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
@@ -293,7 +293,7 @@
deferred.resolve(
response.search,
- response.searchinfo.search,
+ term,
response[ 'search-continue' ]
);
} )
--
To view, visit https://gerrit.wikimedia.org/r/390365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0d1d081e921a0f24a380260dcb5186d98e443a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
