jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/133042 )
Change subject: Specify an explicit text colour on some components that change
the background colour
......................................................................
Specify an explicit text colour on some components that change the background
colour
These components separate themselves from the default colouring of the content
area by specifying a dedicated – typically light grey – background colour.
However they leave text colour unspecified and as a result if the skin should be
white on black instead of black on white this results in these components
becoming
white on white or white on light grey and becoming unreadable.
Fix this by explicitly specifying a text colour to use where the background
colour is set.
Bug: T66732
Change-Id: I12584de40a18929b610d46dceaea73f06fdc6541
---
M resources/src/mediawiki.action/mediawiki.action.history.styles.css
M resources/src/mediawiki.skinning/interface.css
M resources/src/mediawiki/mediawiki.notification.css
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.action/mediawiki.action.history.styles.css
b/resources/src/mediawiki.action/mediawiki.action.history.styles.css
index cad530b..73ec1a7 100644
--- a/resources/src/mediawiki.action/mediawiki.action.history.styles.css
+++ b/resources/src/mediawiki.action/mediawiki.action.history.styles.css
@@ -11,6 +11,7 @@
#pagehistory li.selected {
background-color: #f8f9fa;
+ color: #252525;
border: 1px dashed #a2a9b1;
}
diff --git a/resources/src/mediawiki.skinning/interface.css
b/resources/src/mediawiki.skinning/interface.css
index 3e0d2b9..8cd25d8 100644
--- a/resources/src/mediawiki.skinning/interface.css
+++ b/resources/src/mediawiki.skinning/interface.css
@@ -22,6 +22,7 @@
.editOptions {
background-color: #eaecf0;
+ color: #252525;
border: 1px solid #c8ccd1;
border-top: 0;
padding: 1em 1em 1.5em 1em;
diff --git a/resources/src/mediawiki/mediawiki.notification.css
b/resources/src/mediawiki/mediawiki.notification.css
index 633798d..481980f 100644
--- a/resources/src/mediawiki/mediawiki.notification.css
+++ b/resources/src/mediawiki/mediawiki.notification.css
@@ -15,6 +15,7 @@
margin-bottom: 0.5em;
border: solid 1px #ddd;
background-color: #fcfcfc;
+ color: #252525;
/* Click handler in mediawiki.notification.js */
cursor: pointer;
--
To view, visit https://gerrit.wikimedia.org/r/133042
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12584de40a18929b610d46dceaea73f06fdc6541
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
