Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56368
Change subject: (Bug 46570) - [TUX] Editor width is very limited in page view
mode
......................................................................
(Bug 46570) - [TUX] Editor width is very limited in page view mode
Change-Id: I9a2729ba4d338ab4d2f5d16555d56181bfbeb3ac
---
M resources/css/ext.translate.pagemode.css
M resources/css/ext.translate.proofread.css
M resources/js/ext.translate.editor.js
M resources/js/ext.translate.messagetable.js
M resources/js/ext.translate.pagemode.js
M resources/js/ext.translate.proofread.js
6 files changed, 83 insertions(+), 58 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/68/56368/1
diff --git a/resources/css/ext.translate.pagemode.css
b/resources/css/ext.translate.pagemode.css
index 8d72124..4d8aa06 100644
--- a/resources/css/ext.translate.pagemode.css
+++ b/resources/css/ext.translate.pagemode.css
@@ -1,28 +1,35 @@
.ext-translate-container .tux-messagelist .tux-message-pagemode {
height: auto;
min-height: 50px;
- padding: 40px 0;
margin: 0 auto;
+ vertical-align: middle;
+ background: #FFFFFF;
+}
+
+.ext-translate-container .tux-messagelist .tux-message-pagemode
.tux-message-item-compact {
+ padding: 40px 0;
+ line-height: 50px;
+ overflow: hidden;
+ margin-right: auto;
+ margin-left: auto;
vertical-align: middle;
border-bottom: 1px solid #f0f0f0;
border-left: 1px solid #DDDDDD;
border-right: 1px solid #DDDDDD;
- max-width: 900px;
background: #FFFFFF;
+ max-width: 900px;
}
-.ext-translate-container .tux-messagelist .tux-message-pagemode:hover {
+.ext-translate-container .tux-messagelist .tux-message-pagemode
.tux-message-item-compact:hover {
background: #FCFCFC;
}
.ext-translate-container .tux-messagelist .tux-message-pagemode:first-child {
- margin-top: 10px;
padding-top: 60px;
border-top: 1px solid #DDDDDD;
}
.ext-translate-container .tux-messagelist .tux-message-pagemode:last-child {
- margin-bottom: 10px;
padding-bottom: 60px;
border-bottom: 1px solid #DDDDDD;
}
diff --git a/resources/css/ext.translate.proofread.css
b/resources/css/ext.translate.proofread.css
index 0a4f253..e1ad24f 100644
--- a/resources/css/ext.translate.proofread.css
+++ b/resources/css/ext.translate.proofread.css
@@ -1,16 +1,26 @@
.ext-translate-container .tux-messagelist .tux-message-proofread {
height: auto;
min-height: 50px;
- padding: 40px 0;
margin: 0 auto;
+ vertical-align: middle;
+ background: #FFFFFF;
+}
+
+.ext-translate-container .tux-messagelist .tux-message-proofread
.tux-message-item-compact {
+ padding: 40px 0;
+ line-height: 50px;
+ overflow: hidden;
+ margin-right: auto;
+ margin-left: auto;
vertical-align: middle;
border-bottom: 1px solid #f0f0f0;
border-left: 1px solid #DDDDDD;
border-right: 1px solid #DDDDDD;
- max-width: 900px;
background: #FFFFFF;
+ max-width: 900px;
}
+
.ext-translate-container .tux-messagelist .tux-message-proofread:hover {
background: #FCFCFC;
}
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index e3797b5..41cb21d 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -6,7 +6,7 @@
this.$editor = null;
this.options = options;
this.message = this.options.message;
- this.$messageItem = this.$editTrigger.find( '.tux-message-item'
);
+ this.$messageItem = this.$editTrigger.find( '.message' );
this.shown = false;
this.dirty = false;
this.saving = false;
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index b99457f..145c649 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -192,7 +192,7 @@
.data( 'message', message );
$message = $( '<div>' )
- .addClass( 'row tux-message-item ' + status )
+ .addClass( 'row message tux-message-item ' +
status )
.append(
$( '<div>' )
.addClass( 'eight columns
tux-list-message' )
diff --git a/resources/js/ext.translate.pagemode.js
b/resources/js/ext.translate.pagemode.js
index 3af106e..316768b 100644
--- a/resources/js/ext.translate.pagemode.js
+++ b/resources/js/ext.translate.pagemode.js
@@ -45,24 +45,28 @@
this.$message.append(
$( '<div>' )
- .addClass( 'one column
tux-pagemode-status ' + this.message.properties.status ),
- $( '<div>' )
- .addClass( 'five columns
tux-pagemode-source' )
- .attr( {
- lang: sourceLanguage,
- dir: sourceLanguageDir
- } )
- .html(
mw.translate.formatMessageGently( this.message.definition, this.message.key ) ),
- $( '<div>' )
- .addClass( 'five columns
tux-pagemode-translation' )
- .attr( {
- lang: targetLanguage,
- dir: targetLanguageDir
- } )
- .html(
mw.translate.formatMessageGently( this.message.translation || '',
this.message.key ) ),
- $( '<div>' )
- .attr( 'title', mw.msg(
'translate-edit-title', this.message.key ) )
- .addClass( 'tux-pagemode-edit' )
+ .addClass( 'row
tux-message-item-compact message' )
+ .append(
+ $( '<div>' )
+ .addClass( 'one column
tux-pagemode-status ' + this.message.properties.status ),
+ $( '<div>' )
+ .addClass( 'five
columns tux-pagemode-source' )
+ .attr( {
+ lang:
sourceLanguage,
+ dir:
sourceLanguageDir
+ } )
+ .html(
mw.translate.formatMessageGently( this.message.definition, this.message.key ) ),
+ $( '<div>' )
+ .addClass( 'five
columns tux-pagemode-translation' )
+ .attr( {
+ lang:
targetLanguage,
+ dir:
targetLanguageDir
+ } )
+ .html(
mw.translate.formatMessageGently( this.message.translation || '',
this.message.key ) ),
+ $( '<div>' )
+ .attr( 'title', mw.msg(
'translate-edit-title', this.message.key ) )
+ .addClass(
'tux-pagemode-edit' )
+ )
)
.addClass( this.message.properties.status );
diff --git a/resources/js/ext.translate.proofread.js
b/resources/js/ext.translate.proofread.js
index 6af401c..55f18b8 100644
--- a/resources/js/ext.translate.proofread.js
+++ b/resources/js/ext.translate.proofread.js
@@ -183,38 +183,42 @@
this.$message.append(
$( '<div>' )
- .addClass( 'one column
tux-proofread-status ' + this.message.properties.status ),
- $( '<div>' )
- .addClass( 'five columns
tux-proofread-source' )
- .attr( {
- lang: sourceLanguage,
- dir: sourceLanguageDir
- } )
- .text( this.message.definition ),
- $( '<div>' )
- .addClass( 'five columns
tux-proofread-translation' )
- .attr( {
- lang: targetLanguage,
- dir: targetLanguageDir
- } )
- .text( this.message.translation || '' ),
- $( '<div>' )
- .addClass( 'tux-proofread-action-block
one column' )
+ .addClass( 'row
tux-message-item-compact message' )
.append(
- translatedBySelf ?
- $( '<div>' )
- .addClass(
'translated-by-self' )
- .attr( 'title',
mw.msg( 'tux-proofread-translated-by-self' ) )
- .tipsy( {
gravity: 'e' } ):
- $( [] ),
- $proofreadAction,
- otherReviewers.length ?
- $( '<div>' )
- .addClass(
'tux-proofread-count' )
- .data(
'reviewCount', reviewers.length ) // To update when accepting
- .text(
mw.language.convertNumber( reviewers.length ) ) :
- $( [] ),
- $proofreadEdit
+ $( '<div>' )
+ .addClass( 'one column
tux-proofread-status ' + this.message.properties.status ),
+ $( '<div>' )
+ .addClass( 'five
columns tux-proofread-source' )
+ .attr( {
+ lang:
sourceLanguage,
+ dir:
sourceLanguageDir
+ } )
+ .text(
this.message.definition ),
+ $( '<div>' )
+ .addClass( 'five
columns tux-proofread-translation' )
+ .attr( {
+ lang:
targetLanguage,
+ dir:
targetLanguageDir
+ } )
+ .text(
this.message.translation || '' ),
+ $( '<div>' )
+ .addClass(
'tux-proofread-action-block one column' )
+ .append(
+
translatedBySelf ?
+ $(
'<div>' )
+
.addClass( 'translated-by-self' )
+
.attr( 'title', mw.msg( 'tux-proofread-translated-by-self' ) )
+
.tipsy( { gravity: 'e' } ):
+ $( [] ),
+
$proofreadAction,
+
otherReviewers.length ?
+ $(
'<div>' )
+
.addClass( 'tux-proofread-count' )
+
.data( 'reviewCount', reviewers.length ) // To update when accepting
+
.text( mw.language.convertNumber( reviewers.length ) ) :
+ $( [] ),
+ $proofreadEdit
+ )
)
)
.addClass( this.message.properties.status );
--
To view, visit https://gerrit.wikimedia.org/r/56368
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a2729ba4d338ab4d2f5d16555d56181bfbeb3ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
