Hello Aaron Schulz, Krinkle,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/390645
to review the following change.
Change subject: xenon: pass --mindwidth to flamegraph.pl
......................................................................
xenon: pass --mindwidth to flamegraph.pl
The flame graphs are currently slow to download and slow to render
because the weight threshold for plotting a function is very low.
Increasing the threshold (via --mindwidth=2) causes flamegraph.pl to
omit leaf functions that have a tiny footprint. The resultant flame
graph still contains anything anyone would reasonably care about, but is
more than ten times smaller (600k -> 50k) and renders instantly.
Change-Id: I0a01c694374799718662e16a974decfaf0589ca1
---
M modules/xenon/files/xenon-generate-svgs
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/45/390645/1
diff --git a/modules/xenon/files/xenon-generate-svgs
b/modules/xenon/files/xenon-generate-svgs
index f2ad376..8b40f07 100755
--- a/modules/xenon/files/xenon-generate-svgs
+++ b/modules/xenon/files/xenon-generate-svgs
@@ -11,11 +11,11 @@
mkdir -m0755 -p "$(dirname $svg)"
[ ! -f "$svg" -o "$svg" -ot "$log" ] && {
echo "Generating ${svg}..."
- nice /usr/local/bin/flamegraph.pl --title="$title" "$log" | gzip -9 >
"$svg"
+ nice /usr/local/bin/flamegraph.pl --minwidth=2 --title="$title" "$log"
| gzip -9 > "$svg"
}
[ ! -f "$rsvg" -o "$rsvg" -ot "$log" ] && {
echo "Generating ${rsvg}..."
- nice /usr/local/bin/flamegraph.pl --reverse --colors=blue
--title="$title - reversed" "$log" | gzip -9 > "$rsvg"
+ nice /usr/local/bin/flamegraph.pl --minwidth=2 --reverse --colors=blue
--title="$title - reversed" "$log" | gzip -9 > "$rsvg"
}
done
--
To view, visit https://gerrit.wikimedia.org/r/390645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a01c694374799718662e16a974decfaf0589ca1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
