jenkins-bot has submitted this change and it was merged.
Change subject: Move isWelcomeCreation to GettingStarted.
......................................................................
Move isWelcomeCreation to GettingStarted.
Change-Id: I30e1a3aab1186a84ddabd2893d82668d60ceb374
---
M E3Experiments.hooks.php
M E3Experiments.php
2 files changed, 0 insertions(+), 30 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/E3Experiments.hooks.php b/E3Experiments.hooks.php
index cb5a67c..f5b18bf 100644
--- a/E3Experiments.hooks.php
+++ b/E3Experiments.hooks.php
@@ -7,24 +7,6 @@
*/
class E3ExperimentsHooks {
-
- public static $isWelcomeCreation = false;
-
- /**
- * MakeGlobalVariablesScript hook.
- * Add config vars to mw.config.
- *
- * @param $vars array
- * @param $out OutputPage output page
- * @return bool
- */
- public static function onMakeGlobalVariablesScript( &$vars, $out ) {
- if ( self::$isWelcomeCreation ) {
- $vars[ 'wgIsWelcomeCreation' ] = true;
- }
- return true;
- }
-
/**
* ResourceLoaderGetConfigVars hook
* Sends down static config vars to JavaScript
@@ -50,16 +32,6 @@
public static function onUserCreateForm( &$template ) {
global $wgOut;
$wgOut->addModules( 'ext.E3Experiments.acux' );
- return true;
- }
-
- /*
- * BeforeWelcomeCreation hook
- * Its JS is only applicable to this one page, hence it's a
- * separate module.
- */
- public static function onBeforeWelcomeCreation( &$welcomeCreationMsg,
&$injected_html ) {
- self::$isWelcomeCreation = true;
return true;
}
}
diff --git a/E3Experiments.php b/E3Experiments.php
index 1d47451..36c31f1 100644
--- a/E3Experiments.php
+++ b/E3Experiments.php
@@ -64,8 +64,6 @@
);
// Register hooks
-$wgHooks[ 'BeforeWelcomeCreation' ][] =
'E3ExperimentsHooks::onBeforeWelcomeCreation';
-$wgHooks[ 'MakeGlobalVariablesScript' ][] =
'E3ExperimentsHooks::onMakeGlobalVariablesScript';
$wgHooks[ 'ResourceLoaderGetConfigVars' ][] =
'E3ExperimentsHooks::onResourceLoaderGetConfigVars';
$wgHooks[ 'UserCreateForm' ][] = 'E3ExperimentsHooks::onUserCreateForm';
--
To view, visit https://gerrit.wikimedia.org/r/56363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30e1a3aab1186a84ddabd2893d82668d60ceb374
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/E3Experiments
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
