Huji has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390850 )

Change subject: UserGroupsChanged hook should specify the performer of the 
change
......................................................................

UserGroupsChanged hook should specify the performer of the change

Otherwise, there will be a unit-testing error when Echo is enabled

Bug: T180292
Change-Id: Ibc185c82ad2a03e06e5727a633e6ab6bccce3345
---
M tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/50/390850/1

diff --git 
a/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php 
b/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
index 6970313..457d7af 100644
--- 
a/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
+++ 
b/tests/phpunit/includes/auth/AuthPluginPrimaryAuthenticationProviderTest.php
@@ -73,7 +73,7 @@
                        );
                $provider = new AuthPluginPrimaryAuthenticationProvider( 
$plugin );
 
-               \Hooks::run( 'UserGroupsChanged', [ $user, [ 'added' ], [ 
'removed' ] ] );
+               \Hooks::run( 'UserGroupsChanged', [ $user, [ 'added' ], [ 
'removed' ], $user ] );
        }
 
        public function testOnUserLoggedIn() {

-- 
To view, visit https://gerrit.wikimedia.org/r/390850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc185c82ad2a03e06e5727a633e6ab6bccce3345
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Huji <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to