Gergő Tisza has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390939 )
Change subject: Support MAX_CHARS / MAX_BYTES, somewhat
......................................................................
Support MAX_CHARS / MAX_BYTES, somewhat
Display parameter length limits for ApiSandbox fields, and enforce
them in the widgets where OOUI supports it (that is, max characters
for non-multiline input).
Change-Id: I0f15afe6656765e92582e4e4cead714b31987b8a
---
M resources/Resources.php
M resources/src/mediawiki.special/mediawiki.special.apisandbox.js
2 files changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/39/390939/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 34b0836..adfea4a 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1972,6 +1972,8 @@
'api-help-param-integer-minmax',
'api-help-param-multi-separate',
'api-help-param-multi-max',
+ 'api-help-param-maxbytes',
+ 'api-help-param-maxchars',
'apisandbox-submit-invalid-fields-title',
'apisandbox-submit-invalid-fields-message',
'apisandbox-results',
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index c62685a..4d11f7e 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -345,7 +345,8 @@
$.extend( widget,
WidgetMethods.capsuleWidget );
} else {
widget = new
OO.ui.TextInputWidget( {
- required: Util.apiBool(
pi.required )
+ required: Util.apiBool(
pi.required ),
+ maxLength: pi.maxchars
} );
}
if ( !Util.apiBool( pi.multi ) ) {
@@ -362,7 +363,8 @@
case 'text':
widget = new
OO.ui.MultilineTextInputWidget( {
- required: Util.apiBool(
pi.required )
+ required: Util.apiBool(
pi.required ),
+ maxLength: pi.maxchars
} );
widget.paramInfo = pi;
$.extend( widget,
WidgetMethods.textInputWidget );
@@ -372,7 +374,8 @@
case 'password':
widget = new OO.ui.TextInputWidget( {
type: 'password',
- required: Util.apiBool(
pi.required )
+ required: Util.apiBool(
pi.required ),
+ maxLength: pi.maxchars
} );
widget.paramInfo = pi;
$.extend( widget,
WidgetMethods.textInputWidget );
@@ -1601,6 +1604,18 @@
} ) );
}
}
+ if ( 'maxbytes' in
pi.parameters[ i ] ) {
+
descriptionContainer.append( $( '<div>', {
+ addClass:
'info',
+ append:
Util.parseMsg( 'api-help-param-maxbytes', pi.parameters[ i ].maxbytes )
+ } ) );
+ }
+ if ( 'maxchars' in
pi.parameters[ i ] ) {
+
descriptionContainer.append( $( '<div>', {
+ addClass:
'info',
+ append:
Util.parseMsg( 'api-help-param-maxchars', pi.parameters[ i ].maxchars )
+ } ) );
+ }
helpField = new
OO.ui.FieldLayout(
new OO.ui.Widget( {
$content:
'\xa0',
--
To view, visit https://gerrit.wikimedia.org/r/390939
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f15afe6656765e92582e4e4cead714b31987b8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
