jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/390851 )
Change subject: Set a default value for $reason in onUserGroupsChanged
......................................................................
Set a default value for $reason in onUserGroupsChanged
This will help avoiding errors in unit tests
Bug: T180292
Change-Id: I89e83bd66b7a976b7b5233c897d76000373a31ef
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Hooks.php b/Hooks.php
index 71f490b..cdf0255 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -701,7 +701,7 @@
* @return bool
*/
public static function onUserGroupsChanged( $user, $add, $remove,
$performer,
- $reason, array $oldUGMs = [], array $newUGMs = [] ) {
+ $reason = false, array $oldUGMs = [], array $newUGMs = [] ) {
if ( !$performer ) {
// TODO: Implement support for autopromotion
return true;
--
To view, visit https://gerrit.wikimedia.org/r/390851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89e83bd66b7a976b7b5233c897d76000373a31ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Huji <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
