Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56409
Change subject: Making agent param logic consistant
......................................................................
Making agent param logic consistant
It doesn't make sense to create 2 tokens for the i18n message in one
case and only 1 token in another case. The current i18n messages are
designed to handle only 1 token for agent (for both grammar and display).
Change-Id: I7ab6b5a7b6731e60d0ea6e9e590c15039fdc4459
---
M formatters/BasicFormatter.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/09/56409/1
diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php
index 25de60b..7b7fb86 100644
--- a/formatters/BasicFormatter.php
+++ b/formatters/BasicFormatter.php
@@ -327,9 +327,8 @@
*/
protected function processParam( $event, $param, $message, $user ) {
if ( $param === 'agent' ) {
- // Actually converts to two parameters for gender
support
if ( !$event->getAgent() ) {
- $message->params( '', wfMessage(
'echo-no-agent' )->text() );
+ $message->params( wfMessage( 'echo-no-agent'
)->text() );
} else {
$agent = $event->getAgent();
$message->params( $agent->getName() );
--
To view, visit https://gerrit.wikimedia.org/r/56409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ab6b5a7b6731e60d0ea6e9e590c15039fdc4459
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
