Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391040 )
Change subject: Limit download button to Google Chrome
......................................................................
Limit download button to Google Chrome
As discussed on ticket the download button only appears
to work on Google Chrome on mobile browsers.
Bug: T179529
Bug: T179914
Change-Id: I8bbda8d5a8aa42dd23773fea424c1a70e31d6f85
(cherry picked from commit 7697c262dbb06249576e80e58d6f61f62d1217cf)
---
M resources/skins.minerva.scripts/init.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/40/391040/1
diff --git a/resources/skins.minerva.scripts/init.js
b/resources/skins.minerva.scripts/init.js
index c6bd0be..72eab1f 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -232,7 +232,10 @@
config.get( 'wgMinervaDownloadIcon' ) &&
!page.isMainPage() &&
// The iOS print dialog does not provide pdf
functionality (see T177215)
- !browser.isIos()
+ !browser.isIos() &&
+ // Currently restricted to Chrome (T179529) until we
have good fallbacks for browsers
+ // which do not provide print functionality
+ window.chrome !== undefined
) {
// Because the page actions are floated to the right,
their order in the
// DOM is reversed in the display. The watchstar is
last in the DOM and
--
To view, visit https://gerrit.wikimedia.org/r/391040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bbda8d5a8aa42dd23773fea424c1a70e31d6f85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.31.0-wmf.7
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
