jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/390221 )

Change subject: Use getHtmlCode() instead of getCode() for HTML attribute lang
......................................................................


Use getHtmlCode() instead of getCode() for HTML attribute lang

The HTML attribute lang uses a BCP 47 conform language code.

Change-Id: I16c7521bb08062337d5eb1502d9e7d96c1b0cc48
---
M includes/formatters/EchoHtmlDigestEmailFormatter.php
M includes/formatters/EchoHtmlEmailFormatter.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/formatters/EchoHtmlDigestEmailFormatter.php 
b/includes/formatters/EchoHtmlDigestEmailFormatter.php
index f2f96cc..9c67ea2 100644
--- a/includes/formatters/EchoHtmlDigestEmailFormatter.php
+++ b/includes/formatters/EchoHtmlDigestEmailFormatter.php
@@ -54,7 +54,7 @@
 
        private function renderBody( Language $language, $intro, $digestList, 
$action, $footer ) {
                $alignStart = $language->alignStart();
-               $langCode = $language->getCode();
+               $langCode = $language->getHtmlCode();
                $langDir = $language->getDir();
 
                return <<< EOF
diff --git a/includes/formatters/EchoHtmlEmailFormatter.php 
b/includes/formatters/EchoHtmlEmailFormatter.php
index 4c28fe6..226decc 100644
--- a/includes/formatters/EchoHtmlEmailFormatter.php
+++ b/includes/formatters/EchoHtmlEmailFormatter.php
@@ -46,7 +46,7 @@
 
        private function renderBody( Language $lang, $emailIcon, $summary, 
$action, $intro, $footer ) {
                $alignStart = $lang->alignStart();
-               $langCode = $lang->getCode();
+               $langCode = $lang->getHtmlCode();
                $langDir = $lang->getDir();
 
                $iconImgSrc = Sanitizer::encodeAttribute( $emailIcon );

-- 
To view, visit https://gerrit.wikimedia.org/r/390221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16c7521bb08062337d5eb1502d9e7d96c1b0cc48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to