jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391154 )
Change subject: Modified select2.js to allow for tab to be used as value chooser
......................................................................
Modified select2.js to allow for tab to be used as value chooser
Change-Id: Iba546b12180ff33b68783464fbc92c1f2c5a320d
---
M libs/select2.js
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Yaron Koren: Looks good to me, approved
jenkins-bot: Verified
diff --git a/libs/select2.js b/libs/select2.js
index b85661e..70008bf 100644
--- a/libs/select2.js
+++ b/libs/select2.js
@@ -1381,6 +1381,15 @@
close: function () {
if (!this.opened()) return;
+ // Modification, for Page Forms - prevent the "tab" key from
moving on to the next form input,
+ // for either tokens or combobox inputs, so that it can be used as
a true value selector -
+ // which is especially useful for tokens.
+ // This modification may possibly become unnecessary if/when
select2 is upgraded to a more
+ // recent version, due to the "closeOnSelect" option that select2
now has.
+ if ( event.key == 'Tab' ) {
+ event.preventDefault();
+ }
+
var cid = this.containerId,
scroll = "scroll." + cid,
resize = "resize."+cid,
--
To view, visit https://gerrit.wikimedia.org/r/391154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba546b12180ff33b68783464fbc92c1f2c5a320d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
