Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391212 )
Change subject: Chore: improve about page component typing
......................................................................
Chore: improve about page component typing
Use undefined for the render props parameter since this is what's used
in the type parameters. Also, replace constructor member variable
initialization with class property initialization.
Change-Id: I5d480550808b5e8c278abfa66bba6f014da7ab2c
---
M src/common/pages/about.tsx
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/12/391212/1
diff --git a/src/common/pages/about.tsx b/src/common/pages/about.tsx
index 11524b7..18cfe12 100644
--- a/src/common/pages/about.tsx
+++ b/src/common/pages/about.tsx
@@ -14,10 +14,7 @@
export default {
Component: class extends PreactComponent<undefined, State> {
- constructor() {
- super();
- this.state = { subtitle: "" };
- }
+ state = { subtitle: "" };
componentDidMount() {
// todo: figure out a common way across entry points for defining
@@ -37,7 +34,7 @@
this.setState({ subtitle });
}
- render(_props: void, { subtitle }: State): JSX.Element {
+ render(_props: undefined, { subtitle }: State): JSX.Element {
const links = [
{
href: "https://phabricator.wikimedia.org/tag/marvin/";,
--
To view, visit https://gerrit.wikimedia.org/r/391212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d480550808b5e8c278abfa66bba6f014da7ab2c
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
