jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391170 )
Change subject: Do not limit filesize when running a maintenance script
......................................................................
Do not limit filesize when running a maintenance script
Starting HHVM may require writing very large files, so it can't have the
same file size limit as image scaling etc. The memory limit was already
disabled for much the same reason.
This is the only caller of wfShellWikiCmd() in core which proceeds to
call wfShellExec().
Bug: T145819
Change-Id: I1ab35edbbdb63c2d6f5f578cba2547be79a965ef
---
M includes/SiteConfiguration.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/SiteConfiguration.php b/includes/SiteConfiguration.php
index 7a01a65..2d1d961 100644
--- a/includes/SiteConfiguration.php
+++ b/includes/SiteConfiguration.php
@@ -556,7 +556,7 @@
]
);
// ulimit5.sh breaks this call
- $data = trim( wfShellExec( $cmd, $retVal, [], [
'memory' => 0 ] ) );
+ $data = trim( wfShellExec( $cmd, $retVal, [], [
'memory' => 0, 'filesize' => 0 ] ) );
if ( $retVal != 0 || !strlen( $data ) ) {
throw new MWException( "Failed to run
getConfiguration.php." );
}
--
To view, visit https://gerrit.wikimedia.org/r/391170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ab35edbbdb63c2d6f5f578cba2547be79a965ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
