jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391177 )
Change subject: Fix SVG fallback issues on very small mobile devices
......................................................................
Fix SVG fallback issues on very small mobile devices
- Fixes Wikipedia logo SVG on very small devices by removing the
image resizing in the CSS.
- Fixes Gulp task that wasn't copying PNG fallback to prod directory.
Bug: T129634
Change-Id: I5a5882c0ce758d36874d8bbf223a640b3885a94a
---
M dev/wikipedia.org/assets/postcss/_central-textlogo.css
M gulpfile.js
2 files changed, 1 insertion(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/dev/wikipedia.org/assets/postcss/_central-textlogo.css
b/dev/wikipedia.org/assets/postcss/_central-textlogo.css
index cdde631..48ac14f 100644
--- a/dev/wikipedia.org/assets/postcss/_central-textlogo.css
+++ b/dev/wikipedia.org/assets/postcss/_central-textlogo.css
@@ -46,8 +46,6 @@
}
.central-textlogo__image {
- height: 35px;
- width: auto;
margin-top: 0.8rem;
}
@@ -67,6 +65,5 @@
.central-textlogo__image {
height: auto;
- width: 100px;
}
}
diff --git a/gulpfile.js b/gulpfile.js
index 81e407a..86b4ce4 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -492,7 +492,7 @@
/*
* Copy images to prod folder.
*/
-gulp.task( 'copy-images', [ 'createSvgSprite' ], function () {
+gulp.task( 'copy-images', [ 'createSvgSprite', 'optimizePNGfallback' ],
function () {
var conf = getConfig();
requirePortalParam();
return gulp.src( conf.img.src ).pipe( gulp.dest( conf.img.dest ) );
--
To view, visit https://gerrit.wikimedia.org/r/391177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5882c0ce758d36874d8bbf223a640b3885a94a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/portals
Gerrit-Branch: master
Gerrit-Owner: Jdrewniak <jdrewn...@wikimedia.org>
Gerrit-Reviewer: Jdrewniak <jdrewn...@wikimedia.org>
Gerrit-Reviewer: Mxn <m...@1ec5.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
