jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/390852 )
Change subject: Add missing testcase
......................................................................
Add missing testcase
With this, ReadingListRepository has 100% coverage apart from
the LogicExceptions.
Change-Id: Icb610c88bce1f10345625f73e0eb15a72093a004
---
M tests/src/ReadingListRepositoryTest.php
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/tests/src/ReadingListRepositoryTest.php
b/tests/src/ReadingListRepositoryTest.php
index 8d5bb19..45bdde3 100644
--- a/tests/src/ReadingListRepositoryTest.php
+++ b/tests/src/ReadingListRepositoryTest.php
@@ -620,6 +620,11 @@
$res = $repository->getListEntries( [ $defaultId, $listId ], 2,
2 );
$compare( array_slice( $expectedData, 2, 2 ), $res );
+ $this->assertFailsWith( 'readinglists-db-error-empty-list-ids',
+ function () use ( $repository ) {
+ $repository->getListEntries( [] );
+ }
+ );
$this->assertFailsWith( 'readinglists-db-error-no-such-list',
function () use ( $repository ) {
$repository->getListEntries( [ 123 ] );
--
To view, visit https://gerrit.wikimedia.org/r/390852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb610c88bce1f10345625f73e0eb15a72093a004
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReadingLists
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
