VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391354 )
Change subject: Hide empty OOUI FieldsetLayout headers
......................................................................
Hide empty OOUI FieldsetLayout headers
In cases where the label or the icon are unset the header shouldn't take
up space, nor should it be visible to screenreaders.
That's a workaround, it should not be in the markup. T180535 is the place
to address the unnecessary markup further.
Bug: T177668
Bug: T180535
Change-Id: I39088107e6ab07399f9826dd925df9e1b8dda006
---
M resources/src/mediawiki/htmlform/ooui.styles.less
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/391354/1
diff --git a/resources/src/mediawiki/htmlform/ooui.styles.less
b/resources/src/mediawiki/htmlform/ooui.styles.less
index 1607489..fb1d8eb 100644
--- a/resources/src/mediawiki/htmlform/ooui.styles.less
+++ b/resources/src/mediawiki/htmlform/ooui.styles.less
@@ -1,4 +1,4 @@
-/* OOUIHTMLForm styles */
+// OOUIHTMLForm styles
.mw-htmlform-ooui-wrapper.oo-ui-panelLayout-padded {
padding: 1em 1.25em 1.25em;
}
@@ -43,9 +43,15 @@
}
}
-/* Flatlist styling for PHP widgets... */
+// HACK: Hide empty fieldsetLayoutHeaders, until T180535 isn't resolved
+.oo-ui-fieldsetLayout:not( .oo-ui-labelElement ):not( .oo-ui-iconElement ) >
.oo-ui-fieldsetLayout-header {
+ display: none;
+}
+
+
+// Flatlist styling for PHP widgets...
.mw-htmlform-flatlist .oo-ui-fieldLayout-align-inline,
-/* ...and for JS widgets */
+// ...and for JS widgets
.mw-htmlform-flatlist .oo-ui-radioOptionWidget,
.mw-htmlform-flatlist .oo-ui-checkboxMultioptionWidget {
display: inline-block;
--
To view, visit https://gerrit.wikimedia.org/r/391354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39088107e6ab07399f9826dd925df9e1b8dda006
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
