Mattflaschen has submitted this change and it was merged.
Change subject: Fix two bugs where the wrong field or variable is accessed.
......................................................................
Fix two bugs where the wrong field or variable is accessed.
Change-Id: I3f260c2259b6e2739ccb06ddf616d2d07f3dc5bf
---
M guiders-1.2.8.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mattflaschen: Verified; Looks good to me, approved
Spage: Verified
diff --git a/guiders-1.2.8.js b/guiders-1.2.8.js
index ccc7812..83716bf 100644
--- a/guiders-1.2.8.js
+++ b/guiders-1.2.8.js
@@ -852,14 +852,14 @@
$(myGuider.elem).trigger("guiders.show");
// Create (preload) next guider if it hasn't been created
- var nextGuiderId = guiders.next || null;
+ var nextGuiderId = myGuider.next || null;
var nextGuiderData;
if (nextGuiderId !== null && nextGuiderId !== "") {
if (nextGuiderData = guiders._guiderInits[nextGuiderId]) {
//don't attach if it doesn't exist in DOM
var testInDom = $(nextGuiderData.attachTo);
if ( testInDom.length > 0 ) {
- guiders.createGuider(guiders.nextGuiderData);
+ guiders.createGuider(nextGuiderData);
delete nextGuiderData;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/52349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f260c2259b6e2739ccb06ddf616d2d07f3dc5bf
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/GuidedTour/guiders
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
