jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391284 )
Change subject: Chore: don't restart client on server changes
......................................................................
Chore: don't restart client on server changes
It's true that the client depends on the server. However, the dependency
is limited in scope to an initial server-side rendered HTML page and any
preloads including the client itself. In general, it does not make sense
to restart the client for a server change since an SSR is really what
needs to be triggered. If this functionality can be reliably provided
using a unified Webpack config, we may restore it later.
Bug: T177235
Change-Id: I294fa894e1dcf294c04150b9e876a6858095ec9e
---
M package-lock.json
M package.json
M src/server/index.tsx
3 files changed, 0 insertions(+), 24 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/package-lock.json b/package-lock.json
index b4d2d8e..16fed7a 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -125,15 +125,6 @@
"integrity": "sha1-CIiw8gzH5Y4cIqGIi06WPu+qgQo=",
"dev": true
},
- "@types/touch": {
- "version": "3.1.0",
- "resolved": "https://registry.npmjs.org/@types/touch/-/touch-3.1.0.tgz";,
- "integrity":
"sha512-Bskfd5wztYbQ/mvU4rgHUB3fKcjW2hA6o/F0JN8O+jRPJQDN/2pPV6SmdIiFm2vLyyN/XQzoCULTE05ZOpnNbQ==",
- "dev": true,
- "requires": {
- "@types/node": "8.0.47"
- }
- },
"@types/uglify-js": {
"version": "2.6.29",
"resolved":
"https://registry.npmjs.org/@types/uglify-js/-/uglify-js-2.6.29.tgz";,
diff --git a/package.json b/package.json
index 154659f..a617e79 100644
--- a/package.json
+++ b/package.json
@@ -61,7 +61,6 @@
"@types/mocha": "2.2.44",
"@types/node": "8.0.47",
"@types/node-fetch": "1.6.7",
- "@types/touch": "3.1.0",
"assets-webpack-plugin": "3.5.1",
"clean-webpack-plugin": "0.1.17",
"copyfiles": "1.2.0",
@@ -85,7 +84,6 @@
"sinon": "4.0.2",
"style-loader": "0.19.0",
"svg-inline-loader": "0.8.0",
- "touch": "3.1.0",
"ts-loader": "3.1.1",
"ts-node": "3.3.0",
"typescript": "2.5.3",
diff --git a/src/server/index.tsx b/src/server/index.tsx
index d73d3ed..9352630 100644
--- a/src/server/index.tsx
+++ b/src/server/index.tsx
@@ -73,17 +73,4 @@
server.listen(SERVER_PORT, () => {
console.log(`Server started on ${SERVER_URL}/`); // eslint-disable-line
no-console
-
- if (!PRODUCTION) {
- const touch = require("touch");
-
- // The server is now listening and ready to receive requests. If
- // developmental, touch the client sources to trigger a webpack-dev-server
- // file watch event which triggers a browser reload. If the server was
- // previously running, the browser will be updated with the latest results.
- // The negative offset accounts for:
- // https://github.com/webpack/watchpack/issues/25.
- const nowish: number = Date.now() - 10 * 1000;
- touch("src/client/index.tsx", { time: nowish });
- }
});
--
To view, visit https://gerrit.wikimedia.org/r/391284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I294fa894e1dcf294c04150b9e876a6858095ec9e
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
