Filippo Giunchedi has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391563 )
Change subject: prometheus: sort nodes by certname in get_clusters
......................................................................
prometheus: sort nodes by certname in get_clusters
Avoid spurious (but otherwise harmless) diffs.
Bug: T179395
Change-Id: I32a1c890428f072ac9270a91c955aa23c23843e5
---
M modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Filippo Giunchedi: Looks good to me, approved
Volans: Looks good to me, but someone else must approve
diff --git a/modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
b/modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
index 43dc6de..2cc90e4 100644
--- a/modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
+++ b/modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
@@ -41,7 +41,7 @@
sites = false
end
- function_query_resources([false, 'Class["Profile::Cumin::Target"]',
false]).each do |node|
+ function_query_resources([false, 'Class["Profile::Cumin::Target"]', false,
'certname asc']).each do |node|
cluster = node['parameters']['cluster']
site = node['parameters']['site']
fqdn = node['certname']
--
To view, visit https://gerrit.wikimedia.org/r/391563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32a1c890428f072ac9270a91c955aa23c23843e5
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
