Ejegg has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391571 )
Change subject: Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71
......................................................................
Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71
Change-Id: Id5a2a9768dc64db5259a5988d645e664163ba234
---
M tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/391571/1
diff --git
a/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
b/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
index a2460c5..8135bd9 100644
---
a/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
+++
b/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
@@ -170,9 +170,6 @@
$this->assertFalse( $ret->hard );
}
- /**
- * @skipped till backport fixed
- */
public function testAuthentication() {
$dbw = wfGetDB( DB_MASTER );
$oldHash = $dbw->selectField( 'user', 'user_password', [
'user_name' => 'UTSysop' ] );
@@ -219,8 +216,12 @@
$req->password = 'DoesNotExist';
$ret = $provider->beginPrimaryAuthentication( $reqs );
$this->assertEquals(
- AuthenticationResponse::newAbstain(),
- $provider->beginPrimaryAuthentication( $reqs )
+ AuthenticationResponse::FAIL,
+ $ret->status
+ );
+ $this->assertEquals(
+ 'wrongpassword',
+ $ret->message->getKey()
);
// Validation failure
--
To view, visit https://gerrit.wikimedia.org/r/391571
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5a2a9768dc64db5259a5988d645e664163ba234
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: fundraising/REL1_27
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
