jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391345 )
Change subject: Don't skip tests if the hook is not present
......................................................................
Don't skip tests if the hook is not present
This just hides the error if something's broken with extension
registration because skipped tests don't result in a failed suite.
Instead, explode in everybody's eyes to make it clear there's a
problem.
Change-Id: I2f1e80a1fa4b99d857671c9d1061d34449764f01
---
M tests/phpunit/TemplateStylesHooksTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Anomie: Looks good to me, approved
diff --git a/tests/phpunit/TemplateStylesHooksTest.php
b/tests/phpunit/TemplateStylesHooksTest.php
index c094b40..deb8b7d 100644
--- a/tests/phpunit/TemplateStylesHooksTest.php
+++ b/tests/phpunit/TemplateStylesHooksTest.php
@@ -165,7 +165,7 @@
/** @var Parser $parser */
$parser->firstCallInit();
if ( !isset( $parser->mTagHooks['templatestyles'] ) ) {
- $this->markTestSkipped( 'templatestyles tag hook is not
in the parser' );
+ throw new Exception( 'templatestyles tag hook is not in
the parser' );
}
$out = $parser->parse( $wikitext, Title::newFromText( 'Test' ),
$popt );
$parser->mPreprocessor = null; # Break the Parser <->
Preprocessor cycle
--
To view, visit https://gerrit.wikimedia.org/r/391345
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f1e80a1fa4b99d857671c9d1061d34449764f01
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TemplateStyles
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
