jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391590 )
Change subject: commit_message_validator: homogeinize case in footers ...................................................................... commit_message_validator: homogeinize case in footers Homogeinize case in commit message footers. The logic used is that the '-by' part (i.e, the last part) is always lower case. In the case of 'Change-Id', I left that untouched since may have impact in how gerrit and other tools process changes. Same for 'Depends-On', which integrates with Zuul. While at it, add the missing 'Requested-by' line. Tests are updated as well. Change-Id: Iefc7f9811266cc629f5c43a008b612640a3d8030 Signed-off-by: Arturo Borrero Gonzalez <[email protected]> --- M commit_message_validator/__init__.py M commit_message_validator/tests/data/co-authored-by_ok.msg M commit_message_validator/tests/data/tag-like-in-message_ok.msg 3 files changed, 7 insertions(+), 6 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/commit_message_validator/__init__.py b/commit_message_validator/__init__.py index 09714e2..8455baf 100644 --- a/commit_message_validator/__init__.py +++ b/commit_message_validator/__init__.py @@ -40,16 +40,17 @@ # Header-like lines that we are interested in validating CORRECT_FOOTERS = [ - 'Acked-By', + 'Acked-by', 'Bug', 'Cc', 'Change-Id', - 'Co-Authored-By', + 'Co-Authored-by', 'Depends-On', - 'Reported-By', + 'Requested-by', + 'Reported-by', 'Reviewed-by', 'Signed-off-by', - 'Suggested-By', + 'Suggested-by', 'Tested-by', 'Thanks', ] diff --git a/commit_message_validator/tests/data/co-authored-by_ok.msg b/commit_message_validator/tests/data/co-authored-by_ok.msg index fd170bc..44a4536 100644 --- a/commit_message_validator/tests/data/co-authored-by_ok.msg +++ b/commit_message_validator/tests/data/co-authored-by_ok.msg @@ -6,5 +6,5 @@ display with an 8 character tab leading the line) except in the case of a long URL that is embedded in the message. -Co-Authored-By: Someone awesome <[email protected]> +Co-Authored-by: Someone awesome <[email protected]> Change-Id: Ifcd397165df1cbf9fa04f2044e1bb33ad7414d8d diff --git a/commit_message_validator/tests/data/tag-like-in-message_ok.msg b/commit_message_validator/tests/data/tag-like-in-message_ok.msg index 64f6a88..19c2dc4 100644 --- a/commit_message_validator/tests/data/tag-like-in-message_ok.msg +++ b/commit_message_validator/tests/data/tag-like-in-message_ok.msg @@ -8,5 +8,5 @@ Bug: T91699 Bug: T71589 Bug: T111299 -Co-Authored-By: Gergő Tisza <[email protected]> +Co-Authored-by: Gergő Tisza <[email protected]> Change-Id: If89d24838e326fe25fe867d02181eebcfbb0e196 -- To view, visit https://gerrit.wikimedia.org/r/391590 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefc7f9811266cc629f5c43a008b612640a3d8030 Gerrit-PatchSet: 5 Gerrit-Project: integration/commit-message-validator Gerrit-Branch: master Gerrit-Owner: Arturo Borrero Gonzalez <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Paladox <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
