Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391650 )

Change subject: Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71
......................................................................

Fix tests for I7afaa955a4b393ef00b11e420709bd62b84fbc71

Change-Id: Id5a2a9768dc64db5259a5988d645e664163ba234
(cherry picked from commit 492431bce57aac2a995ea468a9e273b6423cde81)
---
M tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/50/391650/1

diff --git 
a/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
 
b/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
index 088dd00..9c60a8e 100644
--- 
a/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
+++ 
b/tests/phpunit/includes/auth/LocalPasswordPrimaryAuthenticationProviderTest.php
@@ -219,8 +219,12 @@
                $req->password = 'DoesNotExist';
                $ret = $provider->beginPrimaryAuthentication( $reqs );
                $this->assertEquals(
-                       AuthenticationResponse::newAbstain(),
-                       $provider->beginPrimaryAuthentication( $reqs )
+                       AuthenticationResponse::FAIL,
+                       $ret->status
+               );
+               $this->assertEquals(
+                       'wrongpassword',
+                       $ret->message->getKey()
                );
 
                // Validation failure

-- 
To view, visit https://gerrit.wikimedia.org/r/391650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5a2a9768dc64db5259a5988d645e664163ba234
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_28
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to