Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56535
Change subject: Make sure that rangy is initialized only once and that it is
initialized before it is used.
......................................................................
Make sure that rangy is initialized only once and that it is initialized before
it is used.
Change-Id: Ia318908d34e82ae97ae1bf662ad9fc5dc28bf6ba
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/35/56535/1
diff --git a/modules/ve/ce/ve.ce.Surface.js b/modules/ve/ce/ve.ce.Surface.js
index 5d95f1a..42beada 100644
--- a/modules/ve/ce/ve.ce.Surface.js
+++ b/modules/ve/ce/ve.ce.Surface.js
@@ -60,6 +60,9 @@
}
// Initialization
+ if ( !rangy.initialized ) {
+ rangy.init();
+ }
this.$phantoms.addClass( 've-ce-surface-phantoms' );
this.$pasteTarget.addClass( 've-ce-surface-paste' ).prop(
'contenteditable', true );
this.$.append( this.documentView.getDocumentNode().$, this.$phantoms,
this.$pasteTarget );
@@ -122,6 +125,9 @@
* @static
*/
ve.ce.Surface.getSelectionRect = function () {
+ if ( !rangy.initialized ) {
+ rangy.init();
+ }
var rangySel = rangy.getSelection();
return {
start: rangySel.getStartDocumentPos(),
@@ -1284,8 +1290,4 @@
*/
ve.ce.Surface.prototype.disableRendering = function () {
this.renderingEnabled = false;
-};
-
-/* Initialization */
-
-rangy.init();
+};
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/56535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia318908d34e82ae97ae1bf662ad9fc5dc28bf6ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
