Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391749 )
Change subject: Chore: remove superfluous typing on about page
......................................................................
Chore: remove superfluous typing on about page
Now that route page components are Partial (see 12d437f), the extra
typing is no longer needed on about.
Change-Id: I55ea40c4ad008b735bd2ac4db1dc7173ae46eda8
---
M src/common/pages/about.tsx
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/49/391749/1
diff --git a/src/common/pages/about.tsx b/src/common/pages/about.tsx
index 4f36f19..33a3ba9 100644
--- a/src/common/pages/about.tsx
+++ b/src/common/pages/about.tsx
@@ -14,9 +14,9 @@
export default {
Component: class extends PreactComponent<undefined, State> {
- state: State = { subtitle: "" };
+ state = { subtitle: "" };
- componentDidMount?() {
+ componentDidMount() {
// todo: figure out a common way across entry points for defining
// configuration variables that common code could consume. The server has
// server specific vars in config.ts and this here for example are used
@@ -34,7 +34,7 @@
this.setState({ subtitle });
}
- render(_props: undefined, { subtitle }: State): JSX.Element | null {
+ render(_props: undefined, { subtitle }: State) {
const links = [
{
href: "https://phabricator.wikimedia.org/tag/marvin/";,
--
To view, visit https://gerrit.wikimedia.org/r/391749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55ea40c4ad008b735bd2ac4db1dc7173ae46eda8
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
