Hello Krinkle, jenkins-bot, VolkerE, Jdlrobson, Jforrester,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/391776

to review the following change.


Change subject: Revert "Hide empty OOUI FieldsetLayout headers"
......................................................................

Revert "Hide empty OOUI FieldsetLayout headers"

No longer needed after I79fe95e32272f013a1ce4e48a811fa9fbb53f4e6
(released in OOUI 0.24.3).

This reverts commit 382e366196b2b9aa7eb08c92776e6f716f8f5d65.

Change-Id: I37747b4b68801caf442b77e747f486053f279853
---
M resources/src/mediawiki/htmlform/ooui.styles.less
1 file changed, 3 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/391776/1

diff --git a/resources/src/mediawiki/htmlform/ooui.styles.less 
b/resources/src/mediawiki/htmlform/ooui.styles.less
index e78a4ca..1607489 100644
--- a/resources/src/mediawiki/htmlform/ooui.styles.less
+++ b/resources/src/mediawiki/htmlform/ooui.styles.less
@@ -1,4 +1,4 @@
-// OOUIHTMLForm styles
+/* OOUIHTMLForm styles */
 .mw-htmlform-ooui-wrapper.oo-ui-panelLayout-padded {
        padding: 1em 1.25em 1.25em;
 }
@@ -43,14 +43,9 @@
        }
 }
 
-// HACK: Hide empty fieldsetLayoutHeaders, until T180535 isn't resolved
-.oo-ui-fieldsetLayout:not( .oo-ui-labelElement ):not( .oo-ui-iconElement ) > 
.oo-ui-fieldsetLayout-header {
-       display: none;
-}
-
-// Flatlist styling for PHP widgets...
+/* Flatlist styling for PHP widgets... */
 .mw-htmlform-flatlist .oo-ui-fieldLayout-align-inline,
-// ...and for JS widgets
+/* ...and for JS widgets */
 .mw-htmlform-flatlist .oo-ui-radioOptionWidget,
 .mw-htmlform-flatlist .oo-ui-checkboxMultioptionWidget {
        display: inline-block;

-- 
To view, visit https://gerrit.wikimedia.org/r/391776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37747b4b68801caf442b77e747f486053f279853
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to