jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391724 )
Change subject: Remove $wgAuth usage from wrapOldPasswords.php ...................................................................... Remove $wgAuth usage from wrapOldPasswords.php AuthPlugin::allowSetLocalPassword() has been deprecated with no real replacement. (Authentication providers largely describe things from a client POV, so we can check whether the authentication system is configured to use passwords but not whether it uses the user_password field. We could check whether the auth providers include LocalPasswordAuthenticationProvider but that's rather fragile.) There does not seem to be much need, either; we can assume the site admin has at least a basic knowledge of what they are using and would not run wrapOldPasswords.php if the site wasn't using local passwords. Bug: T180537 Change-Id: I34f2d8ad0d801b5460b768ad1d52b29b0a1b08db (cherry picked from commit 1fe65bd2ad2bc92c175273a8dfa9af4626d00509) --- M maintenance/wrapOldPasswords.php 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified diff --git a/maintenance/wrapOldPasswords.php b/maintenance/wrapOldPasswords.php index 2ce19e5..b9fd0ac 100644 --- a/maintenance/wrapOldPasswords.php +++ b/maintenance/wrapOldPasswords.php @@ -40,12 +40,6 @@ } public function execute() { - global $wgAuth; - - if ( !$wgAuth->allowSetLocalPassword() ) { - $this->error( '$wgAuth does not allow local passwords. Aborting.', true ); - } - $passwordFactory = new PasswordFactory(); $passwordFactory->init( RequestContext::getMain()->getConfig() ); -- To view, visit https://gerrit.wikimedia.org/r/391724 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34f2d8ad0d801b5460b768ad1d52b29b0a1b08db Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_27 Gerrit-Owner: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits