WMDE-leszek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391832 )

Change subject: Skip provideGetUndoContent when entity does not contain "labels"
......................................................................

Skip provideGetUndoContent when entity does not contain "labels"

Change-Id: I09acd7ecd7e442ccfc3ea14be4265166217552e8
---
M repo/tests/phpunit/includes/Content/EntityHandlerTest.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/32/391832/1

diff --git a/repo/tests/phpunit/includes/Content/EntityHandlerTest.php 
b/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
index 95d6751..da9c76f 100644
--- a/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
+++ b/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
@@ -24,6 +24,7 @@
 use Wikibase\DataModel\Entity\EntityId;
 use Wikibase\DataModel\Entity\EntityRedirect;
 use Wikibase\DataModel\SerializerFactory;
+use Wikibase\DataModel\Services\Lookup\LabelDescriptionLookup;
 use Wikibase\DataModel\Term\LabelsProvider;
 use Wikibase\EntityContent;
 use Wikibase\Lib\DataTypeDefinitions;
@@ -263,6 +264,10 @@
                /** @var LabelsProvider $e5u4 */
                /** @var LabelsProvider $e5u4u3 */
 
+               if ( $this->newEntity() instanceof LabelsProvider ) {
+                       $this->markTestSkipped( 'provideGetUndoContent only 
works for entities that have labels field' );
+               }
+
                $e1 = $this->newEntity();
                $r1 = $this->fakeRevision( $this->newEntityContent( $e1 ), 1 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/391832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09acd7ecd7e442ccfc3ea14be4265166217552e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to