jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391764 )
Change subject: FieldsetLayout: Hide header when there is no icon or label
......................................................................
FieldsetLayout: Hide header when there is no icon or label
Bug: T180535
Change-Id: I79fe95e32272f013a1ce4e48a811fa9fbb53f4e6
---
M src/styles/layouts/FieldsetLayout.less
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/styles/layouts/FieldsetLayout.less
b/src/styles/layouts/FieldsetLayout.less
index 8d8e8e1..2fe85d3 100644
--- a/src/styles/layouts/FieldsetLayout.less
+++ b/src/styles/layouts/FieldsetLayout.less
@@ -11,18 +11,20 @@
display: table-cell; // Prevent overflowing content in Firefox
(responsive layouts)
}
+ > .oo-ui-fieldsetLayout-header {
+ display: none;
+ }
+
+ &.oo-ui-iconElement > .oo-ui-fieldsetLayout-header,
&.oo-ui-labelElement > .oo-ui-fieldsetLayout-header {
color: inherit; // Correct the color inheritance from
`fieldset` elements in IE
- display: inline-table; // Correct the text wrapping in Edge and
IE
+ // Use 'inline-table' instead of just 'block' to correct the
text wrapping in Edge and IE
+ display: inline-table;
box-sizing: border-box; // Correct the text wrapping in Edge
and IE
padding: 0;
white-space: normal; // Correct the text wrapping in Edge and IE
float: left; // Prevent positioning problems in Firefox, see
T146462
width: 100%; // Take the whole available width, this is needed
because of 'float' above
-
- > .oo-ui-labelElement-label:empty {
- display: none;
- }
}
&-group {
--
To view, visit https://gerrit.wikimedia.org/r/391764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79fe95e32272f013a1ce4e48a811fa9fbb53f4e6
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
