jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391886 )

Change subject: PHP DropdownInputWidget: Firefox 57 ignores hack with whitespace
......................................................................


PHP DropdownInputWidget: Firefox 57 ignores hack with whitespace

Firefox 57 ignores attribute selector hack rule for IE 6-8
with additional whitespace in attribute selector as
`select:not( [ no-ie ] ) {}`.

Bug: T180138
Change-Id: I6258f427ad81be6f253b1c15d3908950732d769a
---
M src/themes/wikimediaui/widgets.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/wikimediaui/widgets.less 
b/src/themes/wikimediaui/widgets.less
index 750c435..8b66cb7 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -677,7 +677,7 @@
 
                // Add custom dropdown arrow
                // Support: Everything besides IE 6-8
-               &:not( [ no-ie ] ) {
+               &:not( [no-ie] ) { // stylelint-disable-line 
selector-attribute-brackets-space-inside
                        background-position: right 1.75em center;
                        width: e( 'calc( 100% + 1em )' );
                        height: @size-base;

-- 
To view, visit https://gerrit.wikimedia.org/r/391886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6258f427ad81be6f253b1c15d3908950732d769a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to