Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391977 )

Change subject: If timestamp is null load revision time
......................................................................

If timestamp is null load revision time

Passing null to wfTimestamp will result in the current time.
Protect against that happening

Bug: T180103
Change-Id: I6ef9577bf52609bf387b0146f1d8a4a53be58cd7
---
M includes/skins/SkinMinerva.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/77/391977/1

diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 344bc06..fa2ede2 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -729,6 +729,11 @@
                $isMainPage = $title->isMainPage();
                // Get rev_timestamp of current revision (preloaded by 
MediaWiki core)
                $timestamp = $this->getOutput()->getRevisionTimestamp();
+               # No cached timestamp, load it from the database
+               if ( $timestamp === null ) {
+                       $timestamp = Revision::getTimestampFromId( 
$this->getTitle(), $this->getRevisionId() );
+               }
+
                // Main pages tend to include transclusions (see bug 51924)
                if ( $isMainPage ) {
                        $lastModified = $this->msg( 'mobile-frontend-history' 
)->plain();

-- 
To view, visit https://gerrit.wikimedia.org/r/391977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ef9577bf52609bf387b0146f1d8a4a53be58cd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to