BBlack has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392178 )
Change subject: normalize_path_encoding: decode tilde for upload
......................................................................
normalize_path_encoding: decode tilde for upload
Bug: T171881
Change-Id: Ifccc52c8f8b04e65987cba939e093594b5d7ad4b
---
M modules/varnish/templates/normalize_path.inc.vcl.erb
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/78/392178/1
diff --git a/modules/varnish/templates/normalize_path.inc.vcl.erb
b/modules/varnish/templates/normalize_path.inc.vcl.erb
index 9bea315..a3fb89f 100644
--- a/modules/varnish/templates/normalize_path.inc.vcl.erb
+++ b/modules/varnish/templates/normalize_path.inc.vcl.erb
@@ -32,13 +32,13 @@
* its own functional path-delimiting slashes unencoded.
*
* upload.wikimedia.org:---------
- * MW seems to use PHP's urlencode() directly when translating from MediaWiki
- * File titles to storage URLs. Note the filenames never contain spaces
- * (would be underscores), and cannot have forward slashes (which will still
- * exist in the rest of the path un-encoded). . The rules we should obey to
- * be consistent with it would be:
+ * MW seems to use PHP's rawurlencode() directly when translating from
+ * MediaWiki File titles to storage URLs. Note the filenames never contain
+ * spaces (would be underscores), and cannot have forward slashes (which will
+ * still exist in the rest of the path un-encoded). The rules we should obey
+ * to be consistent with it would be:
*
- * Always-Decode: 0-9 A-Z a-z - . _ /
+ * Always-Decode: 0-9 A-Z a-z - . _ ~ /
* Always-Encode: Everything Else
******************************************************************************/
@@ -55,7 +55,7 @@
//@ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _
0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,0,1,
//` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~ <DEL>
- 0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,
+ 0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,1,0,
// 0x80-0xFF (all unprintable)
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
--
To view, visit https://gerrit.wikimedia.org/r/392178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifccc52c8f8b04e65987cba939e093594b5d7ad4b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
