Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392214 )
Change subject: [MCR] tests for Revision::getArchiveQueryInfo
......................................................................
[MCR] tests for Revision::getArchiveQueryInfo
Bug: T180210
Change-Id: Icb016be8d69dfdfa83f44bbc4fb259b5beb30678
---
M tests/phpunit/includes/RevisionTest.php
1 file changed, 181 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/14/392214/1
diff --git a/tests/phpunit/includes/RevisionTest.php
b/tests/phpunit/includes/RevisionTest.php
index a4f55d0..f860a7d 100644
--- a/tests/phpunit/includes/RevisionTest.php
+++ b/tests/phpunit/includes/RevisionTest.php
@@ -756,4 +756,185 @@
);
}
+ public function provideGetArchiveQueryInfo() {
+ yield 'wgContentHandlerUseDB false,
wgCommentTableSchemaMigrationStage OLD' => [
+ [
+ 'wgContentHandlerUseDB' => false,
+ 'wgCommentTableSchemaMigrationStage' =>
MIGRATION_OLD,
+ ],
+ [
+ 'tables' => [ 'archive' ],
+ 'fields' => [
+ 'ar_id',
+ 'ar_page_id',
+ 'ar_rev_id',
+ 'ar_text',
+ 'ar_text_id',
+ 'ar_timestamp',
+ 'ar_user_text',
+ 'ar_user',
+ 'ar_minor_edit',
+ 'ar_deleted',
+ 'ar_len',
+ 'ar_parent_id',
+ 'ar_sha1',
+ 'ar_comment_text' => 'ar_comment',
+ 'ar_comment_data' => 'NULL',
+ 'ar_comment_cid' => 'NULL',
+ ],
+ 'joins' => [],
+ ]
+ ];
+ yield 'wgContentHandlerUseDB true,
wgCommentTableSchemaMigrationStage OLD' => [
+ [
+ 'wgContentHandlerUseDB' => true,
+ 'wgCommentTableSchemaMigrationStage' =>
MIGRATION_OLD,
+ ],
+ [
+ 'tables' => [ 'archive' ],
+ 'fields' => [
+ 'ar_id',
+ 'ar_page_id',
+ 'ar_rev_id',
+ 'ar_text',
+ 'ar_text_id',
+ 'ar_timestamp',
+ 'ar_user_text',
+ 'ar_user',
+ 'ar_minor_edit',
+ 'ar_deleted',
+ 'ar_len',
+ 'ar_parent_id',
+ 'ar_sha1',
+ 'ar_comment_text' => 'ar_comment',
+ 'ar_comment_data' => 'NULL',
+ 'ar_comment_cid' => 'NULL',
+ 'ar_content_format',
+ 'ar_content_model',
+ ],
+ 'joins' => [],
+ ]
+ ];
+ yield 'wgContentHandlerUseDB false,
wgCommentTableSchemaMigrationStage WRITE_BOTH' => [
+ [
+ 'wgContentHandlerUseDB' => false,
+ 'wgCommentTableSchemaMigrationStage' =>
MIGRATION_WRITE_BOTH,
+ ],
+ [
+ 'tables' => [
+ 'archive',
+ 'comment_ar_comment' => 'comment',
+ ],
+ 'fields' => [
+ 'ar_id',
+ 'ar_page_id',
+ 'ar_rev_id',
+ 'ar_text',
+ 'ar_text_id',
+ 'ar_timestamp',
+ 'ar_user_text',
+ 'ar_user',
+ 'ar_minor_edit',
+ 'ar_deleted',
+ 'ar_len',
+ 'ar_parent_id',
+ 'ar_sha1',
+ 'ar_comment_text' => 'COALESCE(
comment_ar_comment.comment_text, ar_comment )',
+ 'ar_comment_data' =>
'comment_ar_comment.comment_data',
+ 'ar_comment_cid' =>
'comment_ar_comment.comment_id',
+ ],
+ 'joins' => [
+ 'comment_ar_comment' => [
+ 'LEFT JOIN',
+ 'comment_ar_comment.comment_id
= ar_comment_id',
+ ],
+ ],
+ ]
+ ];
+ yield 'wgContentHandlerUseDB false,
wgCommentTableSchemaMigrationStage WRITE_NEW' => [
+ [
+ 'wgContentHandlerUseDB' => false,
+ 'wgCommentTableSchemaMigrationStage' =>
MIGRATION_WRITE_NEW,
+ ],
+ [
+ 'tables' => [
+ 'archive',
+ 'comment_ar_comment' => 'comment',
+ ],
+ 'fields' => [
+ 'ar_id',
+ 'ar_page_id',
+ 'ar_rev_id',
+ 'ar_text',
+ 'ar_text_id',
+ 'ar_timestamp',
+ 'ar_user_text',
+ 'ar_user',
+ 'ar_minor_edit',
+ 'ar_deleted',
+ 'ar_len',
+ 'ar_parent_id',
+ 'ar_sha1',
+ 'ar_comment_text' => 'COALESCE(
comment_ar_comment.comment_text, ar_comment )',
+ 'ar_comment_data' =>
'comment_ar_comment.comment_data',
+ 'ar_comment_cid' =>
'comment_ar_comment.comment_id',
+ ],
+ 'joins' => [
+ 'comment_ar_comment' => [
+ 'LEFT JOIN',
+ 'comment_ar_comment.comment_id
= ar_comment_id',
+ ],
+ ],
+ ]
+ ];
+ yield 'wgContentHandlerUseDB false,
wgCommentTableSchemaMigrationStage NEW' => [
+ [
+ 'wgContentHandlerUseDB' => false,
+ 'wgCommentTableSchemaMigrationStage' =>
MIGRATION_NEW,
+ ],
+ [
+ 'tables' => [
+ 'archive',
+ 'comment_ar_comment' => 'comment',
+ ],
+ 'fields' => [
+ 'ar_id',
+ 'ar_page_id',
+ 'ar_rev_id',
+ 'ar_text',
+ 'ar_text_id',
+ 'ar_timestamp',
+ 'ar_user_text',
+ 'ar_user',
+ 'ar_minor_edit',
+ 'ar_deleted',
+ 'ar_len',
+ 'ar_parent_id',
+ 'ar_sha1',
+ 'ar_comment_text' =>
'comment_ar_comment.comment_text',
+ 'ar_comment_data' =>
'comment_ar_comment.comment_data',
+ 'ar_comment_cid' =>
'comment_ar_comment.comment_id',
+ ],
+ 'joins' => [
+ 'comment_ar_comment' => [
+ 'JOIN',
+ 'comment_ar_comment.comment_id
= ar_comment_id',
+ ],
+ ],
+ ]
+ ];
+ }
+
+ /**
+ * @covers Revision::getArchiveQueryInfo
+ * @dataProvider provideGetArchiveQueryInfo
+ */
+ public function testGetArchiveQueryInfo( $globals, $expected ) {
+ $this->setMwGlobals( $globals );
+ $this->assertEquals(
+ $expected,
+ Revision::getArchiveQueryInfo()
+ );
+ }
+
}
--
To view, visit https://gerrit.wikimedia.org/r/392214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb016be8d69dfdfa83f44bbc4fb259b5beb30678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
