Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56583
Change subject: Pass the source and target languages as options to proofread,
pagemode plugins
......................................................................
Pass the source and target languages as options to proofread, pagemode plugins
Change-Id: Ie83bbb77000a85e28eda3012b55865f0e4235b31
---
M resources/js/ext.translate.messagetable.js
M resources/js/ext.translate.pagemode.js
M resources/js/ext.translate.proofread.js
3 files changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/83/56583/1
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index b99457f..ac44493 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -254,7 +254,10 @@
.data( 'message', message );
this.$container.append( $message );
- $message.proofread();
+ $message.proofread( {
+ sourcelangcode: this.$container.data(
'sourcelangcode' ),
+ targetlangcode: this.$container.data(
'targetlangcode' )
+ } );
return $message;
},
@@ -267,7 +270,10 @@
.data( 'message', message );
this.$container.append( $message );
- $message.pagemode();
+ $message.pagemode( {
+ sourcelangcode: this.$container.data(
'sourcelangcode' ),
+ targetlangcode: this.$container.data(
'targetlangcode' )
+ } );
},
/**
diff --git a/resources/js/ext.translate.pagemode.js
b/resources/js/ext.translate.pagemode.js
index 3af106e..682dec0 100644
--- a/resources/js/ext.translate.pagemode.js
+++ b/resources/js/ext.translate.pagemode.js
@@ -1,9 +1,9 @@
( function ( $, mw ) {
'use strict';
- function PageMode( element ) {
+ function PageMode( element, options ) {
this.$message = $( element );
- this.$messagetable = $( '.tux-messagelist' );
+ this.options = options;
this.message = this.$message.data( 'message' );
this.init();
this.listen();
@@ -38,9 +38,9 @@
render: function () {
var targetLanguage, targetLanguageDir, sourceLanguage,
sourceLanguageDir;
- sourceLanguage = this.$messagetable.data(
'sourcelangcode' );
+ sourceLanguage = this.options.sourcelangcode;
sourceLanguageDir = $.uls.data.getDir( sourceLanguage );
- targetLanguage = this.$messagetable.data(
'targetlangcode' );
+ targetLanguage = this.options.targetlangcode;
targetLanguageDir = $.uls.data.getDir( targetLanguage );
this.$message.append(
diff --git a/resources/js/ext.translate.proofread.js
b/resources/js/ext.translate.proofread.js
index 6af401c..4768e51 100644
--- a/resources/js/ext.translate.proofread.js
+++ b/resources/js/ext.translate.proofread.js
@@ -98,9 +98,9 @@
}
} );
- function Proofread( element ) {
+ function Proofread( element, options ) {
this.$message = $( element );
- this.$container = $( '.tux-messagelist' );
+ this.options = options;
this.message = this.$message.data( 'message' );
this.init();
this.listen();
@@ -156,9 +156,9 @@
translatedBySelf = (
this.message.properties['last-translator-text'] === mw.user.getName() );
proofreadBySelf = $.inArray( userId, reviewers ) > -1;
- sourceLanguage = this.$container.data( 'sourcelangcode'
);
+ sourceLanguage = this.options.sourcelangcode;
sourceLanguageDir = $.uls.data.getDir( sourceLanguage );
- targetLanguage = this.$container.data( 'targetlangcode'
);
+ targetLanguage = this.options.targetlangcode;
targetLanguageDir = $.uls.data.getDir( targetLanguage );
$proofreadAction = $( '<div>' )
--
To view, visit https://gerrit.wikimedia.org/r/56583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie83bbb77000a85e28eda3012b55865f0e4235b31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
