jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392206 )
Change subject: @since tags & private class properties for TitleValue
......................................................................
@since tags & private class properties for TitleValue
Change-Id: I3d8315ade6aa70bda43d90b0b32b730d8c9cbd2e
---
M includes/title/TitleValue.php
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/title/TitleValue.php b/includes/title/TitleValue.php
index 7c370f1..e2ee967 100644
--- a/includes/title/TitleValue.php
+++ b/includes/title/TitleValue.php
@@ -34,25 +34,26 @@
* @since 1.23
*/
class TitleValue implements LinkTarget {
+
/**
* @var int
*/
- protected $namespace;
+ private $namespace;
/**
* @var string
*/
- protected $dbkey;
+ private $dbkey;
/**
* @var string
*/
- protected $fragment;
+ private $fragment;
/**
* @var string
*/
- protected $interwiki;
+ private $interwiki;
/**
* Constructs a TitleValue.
@@ -89,6 +90,7 @@
}
/**
+ * @since 1.23
* @return int
*/
public function getNamespace() {
@@ -105,6 +107,7 @@
}
/**
+ * @since 1.23
* @return string
*/
public function getFragment() {
@@ -122,6 +125,7 @@
/**
* Returns the title's DB key, as supplied to the constructor,
* without namespace prefix or fragment.
+ * @since 1.23
*
* @return string
*/
@@ -132,6 +136,7 @@
/**
* Returns the title in text form,
* without namespace prefix or fragment.
+ * @since 1.23
*
* This is computed from the DB key by replacing any underscores with
spaces.
*
@@ -185,6 +190,7 @@
* Returns a string representation of the title, for logging. This is
purely informative
* and must not be used programmatically. Use the appropriate
TitleFormatter to generate
* the correct string representation for a given use.
+ * @since 1.23
*
* @return string
*/
--
To view, visit https://gerrit.wikimedia.org/r/392206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8315ade6aa70bda43d90b0b32b730d8c9cbd2e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
