jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391227 )
Change subject: Extract FormId regex pattern into a constant
......................................................................
Extract FormId regex pattern into a constant
This is a super-tiny patch done in preparation for future updates to
this class.
Change-Id: I05c52411d30aafaecf1d56da9ce51057ece943ef
---
M src/DataModel/FormId.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/DataModel/FormId.php b/src/DataModel/FormId.php
index a54e2a0..e4089dc 100644
--- a/src/DataModel/FormId.php
+++ b/src/DataModel/FormId.php
@@ -10,6 +10,8 @@
*/
class FormId {
+ const PATTERN = '/^F[1-9]\d*\z/';
+
/**
* @var string
*/
@@ -21,9 +23,9 @@
public function __construct( $serialization ) {
Assert::parameterType( 'string', $serialization,
'$serialization' );
Assert::parameter(
- preg_match( '/^F[1-9]\d*\z/', $serialization ),
+ preg_match( self::PATTERN, $serialization ),
'$serialization',
- 'Form ID must match "F[1-9]\d*", given: ' .
$serialization
+ 'Form ID must match "' . self::PATTERN . '", given: ' .
$serialization
);
$this->serialization = $serialization;
--
To view, visit https://gerrit.wikimedia.org/r/391227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05c52411d30aafaecf1d56da9ce51057ece943ef
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
