jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392482 )
Change subject: Fix sender name in messages sent via Special:SendBoardBlast
......................................................................
Fix sender name in messages sent via Special:SendBoardBlast
In I93e7e67afd0bc36018ade0611e0840b01d515060 I had converted
SpecialSendBoardBlast.php to use RequestContext instead of globals, but
this didn't take into account the fact that the execute() method already
had a local variable named $user. Now the $user variable represents the
current user (sender) while the $recipient variable is used for the
message recipient.
Change-Id: I85dc740c0569ccfb1bd1f6587152f51b2bd7b629
---
M UserBoard/SpecialSendBoardBlast.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
SamanthaNguyen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/UserBoard/SpecialSendBoardBlast.php
b/UserBoard/SpecialSendBoardBlast.php
index 3bc307d..a1e67c9 100644
--- a/UserBoard/SpecialSendBoardBlast.php
+++ b/UserBoard/SpecialSendBoardBlast.php
@@ -62,11 +62,11 @@
$count = 0;
$user_ids_to = explode( ',', $request->getVal( 'ids' )
);
foreach ( $user_ids_to as $user_id ) {
- $user = User::newFromId( $user_id );
- $user->loadFromId();
- $user_name = $user->getName();
+ $recipient = User::newFromId( $user_id );
+ $recipient->loadFromId();
+ $user_name = $recipient->getName();
$b->sendBoardMessage(
- $user->getID(),
+ $user->getId(),
$user->getName(),
$user_id,
$user_name,
--
To view, visit https://gerrit.wikimedia.org/r/392482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85dc740c0569ccfb1bd1f6587152f51b2bd7b629
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Lewis Cawte <[email protected]>
Gerrit-Reviewer: SamanthaNguyen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
